From: Daniel Borkmann <daniel@iogearbox.net>
To: Alexei Starovoitov <ast@plumgrid.com>,
"David S. Miller" <davem@davemloft.net>
Cc: Michael Holzheu <holzheu@linux.vnet.ibm.com>,
Martin Schwidefsky <schwidefsky@de.ibm.com>,
netdev@vger.kernel.org
Subject: Re: [PATCH net-next] bpf: add missing rcu protection when releasing programs from prog_array
Date: Sat, 30 May 2015 11:02:32 +0200 [thread overview]
Message-ID: <55697CA8.2010606@iogearbox.net> (raw)
In-Reply-To: <5568F4C3.5010007@plumgrid.com>
On 05/30/2015 01:22 AM, Alexei Starovoitov wrote:
...
> Like __sk_filter_release() and __bpf_prog_release() should be removed.
The whole filter cleanup procedure needs to be simplified a bit, got a
bit too complicated over time, agreed.
> Of course, it's a grey line when to introduce a helper and when not to,
> but just because two lines are close enough between two functions it
> doesn't mean that helper is warranted. In this bpf_prog_put() case
> I think helper is not needed _today_. If it grows, we'll reconsider.
Yes, that's what I meant.
next prev parent reply other threads:[~2015-05-30 9:02 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-05-29 2:26 [PATCH net-next] bpf: add missing rcu protection when releasing programs from prog_array Alexei Starovoitov
2015-05-29 9:10 ` Daniel Borkmann
2015-05-29 23:22 ` Alexei Starovoitov
2015-05-30 9:02 ` Daniel Borkmann [this message]
2015-05-31 7:28 ` David Miller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=55697CA8.2010606@iogearbox.net \
--to=daniel@iogearbox.net \
--cc=ast@plumgrid.com \
--cc=davem@davemloft.net \
--cc=holzheu@linux.vnet.ibm.com \
--cc=netdev@vger.kernel.org \
--cc=schwidefsky@de.ibm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).