From: Florian Fainelli <f.fainelli@gmail.com>
To: Scott Feldman <sfeldma@gmail.com>, Guenter Roeck <linux@roeck-us.net>
Cc: Vivien Didelot <vivien.didelot@savoirfairelinux.com>,
Netdev <netdev@vger.kernel.org>, Andrew Lunn <andrew@lunn.ch>,
Jerome Oufella <jerome.oufella@savoirfairelinux.com>,
Chris Healy <cphealy@gmail.com>, Jiri Pirko <jiri@resnulli.us>
Subject: Re: [RFC 0/3] DSA and Marvell 88E6352 802.1q support
Date: Mon, 01 Jun 2015 17:14:33 -0700 [thread overview]
Message-ID: <556CF569.2050408@gmail.com> (raw)
In-Reply-To: <CAE4R7bBavvmLS=Ra66eeEonZ7x4Syq_PQJ928Ry-f3O9yA9yRg@mail.gmail.com>
On 31/05/15 14:21, Scott Feldman wrote:
>> Hi Scott,
>>
>> If I understand you correctly, that means we would expect users to
>> use bridge commands even on non-bridged dsa ports. I don't think we can
>> make this kind of assumption. Users will expect configure VLANs on
>> non-bridge ports as they would normally configure VLANs, using the 8021q
>> module.
>>
>> So I guess we'll have to support the ndo ops for dsa.
>
> I think that's fine. There is flexibility here. Using the "bridge"
> command for non-bridged ports is a little weird. You'll still need
> setlink to get the PVID/untagged flags, for the bridged-port cases, as
> was done in the original RFC patch.
>
> I wonder if a new command "vlan" for the iproute2 pkg would be useful?
> It would absorb the vconfig command options, making vconfig obsolete.
> Some of vconfig functionality is already in iproute2, for example "ip
> link add link ... type vlan ..."
I would definitively like to see that. Right now, this is a little
confusing for users to realize that using bridge + VLAN filtering is a
lot more powerful to configure a switch rather than using
vconfig/iproute add type vlan.
--
Florian
next prev parent reply other threads:[~2015-06-02 0:15 UTC|newest]
Thread overview: 32+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-05-26 22:29 DSA and underlying 802.1Q encapsulation Vivien Didelot
2015-05-26 22:51 ` Guenter Roeck
2015-05-27 20:48 ` Vivien Didelot
2015-05-27 21:02 ` Guenter Roeck
2015-05-27 21:05 ` Andrew Lunn
2015-05-27 22:51 ` Guenter Roeck
2015-05-28 1:46 ` Andrew Lunn
2015-05-28 5:01 ` Guenter Roeck
2015-05-28 13:44 ` Vivien Didelot
2015-05-28 14:19 ` Guenter Roeck
2015-05-28 21:37 ` [RFC 0/3] DSA and Marvell 88E6352 802.1q support Vivien Didelot
2015-05-28 21:37 ` [RFC 1/3] net: dsa: add basic support for VLAN ndo Vivien Didelot
2015-05-29 4:46 ` Scott Feldman
2015-05-29 15:24 ` Or Gerlitz
2015-05-29 15:38 ` Vivien Didelot
2015-05-29 15:51 ` Or Gerlitz
2015-05-29 22:15 ` Guenter Roeck
2015-05-29 22:57 ` Vivien Didelot
2015-05-31 16:14 ` Scott Feldman
2015-05-28 21:37 ` [RFC 2/3] net: dsa: mv88e6xxx: add support for VTU operations Vivien Didelot
2015-05-29 22:38 ` Guenter Roeck
2015-05-28 21:37 ` [RFC 3/3] net: dsa: mv88e6352: add support for VLAN Vivien Didelot
2015-05-29 5:02 ` [RFC 0/3] DSA and Marvell 88E6352 802.1q support Scott Feldman
2015-05-29 15:40 ` Vivien Didelot
2015-05-29 22:42 ` Guenter Roeck
2015-05-31 16:48 ` Scott Feldman
2015-05-31 17:06 ` Guenter Roeck
2015-05-31 21:21 ` Scott Feldman
2015-06-02 0:14 ` Florian Fainelli [this message]
2015-06-02 0:18 ` Vivien Didelot
2015-06-02 6:18 ` Scott Feldman
2015-06-02 23:23 ` Vivien Didelot
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=556CF569.2050408@gmail.com \
--to=f.fainelli@gmail.com \
--cc=andrew@lunn.ch \
--cc=cphealy@gmail.com \
--cc=jerome.oufella@savoirfairelinux.com \
--cc=jiri@resnulli.us \
--cc=linux@roeck-us.net \
--cc=netdev@vger.kernel.org \
--cc=sfeldma@gmail.com \
--cc=vivien.didelot@savoirfairelinux.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).