From: Linhaifeng <haifeng.lin@huawei.com>
To: Rusty Russell <rusty@rustcorp.com.au>, <netdev@vger.kernel.org>
Cc: <virtualization@lists.linux-foundation.org>,
"Michael S. Tsirkin" <mst@redhat.com>
Subject: Re: virtio-net: why not always to set avail->flags to VRING_AVAIL_F_NO_INTERRUPT
Date: Thu, 4 Jun 2015 10:35:19 +0800 [thread overview]
Message-ID: <556FB967.6010103@huawei.com> (raw)
In-Reply-To: <87k2vkuvg8.fsf@rustcorp.com.au>
On 2015/6/4 9:13, Rusty Russell wrote:
> Linhaifeng <haifeng.lin@huawei.com> writes:
>> Hi,
>>
>> I'm a newbie and have a question about vring_new_virtqueue function.
>>
>> Why we set avail->flags to VRING_AVAIL_F_NO_INTERRUPT when no callbacks?
>> I think we should set avail->flags to VRING_AVAIL_F_NO_INTERRUPT even if no callbacks.
>
> Hi Linhaifeng,
>
> Not sure I understand your question, but I'll try to answer.
>
> We don't set VRING_AVAIL_F_NO_INTERRUPT if there's a callback because we
> want that callback called. Otherwise callback will never be used.
>
> Cheers,
> Rusty.
>
>
Hi Rusty,
Thank you for your response.
I mean should we set VRING_AVAIL_F_NO_INTERRUPT when virtqueue is initialized whether there is callback or not?
As it would be set in function virtqueue_disable_cb and virtqueue_enable_cb_prepare later.
Regards,
Haifeng
next prev parent reply other threads:[~2015-06-04 2:35 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-06-03 6:32 virtio-net: why not always to set avail->flags to VRING_AVAIL_F_NO_INTERRUPT Linhaifeng
2015-06-04 1:13 ` Rusty Russell
2015-06-04 2:35 ` Linhaifeng [this message]
2015-06-04 19:52 ` Rusty Russell
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=556FB967.6010103@huawei.com \
--to=haifeng.lin@huawei.com \
--cc=mst@redhat.com \
--cc=netdev@vger.kernel.org \
--cc=rusty@rustcorp.com.au \
--cc=virtualization@lists.linux-foundation.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).