From: Julien Grall <julien.grall@citrix.com>
To: Joe Perches <joe@perches.com>
Cc: <xen-devel@lists.xenproject.org>, <ian.campbell@citrix.com>,
<stefano.stabellini@eu.citrix.com>,
<linux-kernel@vger.kernel.org>,
"David Vrabel" <david.vrabel@citrix.com>,
Konrad Rzeszutek Wilk <konrad.wilk@oracle.com>,
Boris Ostrovsky <boris.ostrovsky@oracle.com>,
<netdev@vger.kernel.org>
Subject: Re: [PATCH v2 1/2] net/xen-netfront: Correct printf format in xennet_get_responses
Date: Thu, 4 Jun 2015 13:45:00 +0100 [thread overview]
Message-ID: <5570484C.8040201@citrix.com> (raw)
In-Reply-To: <1433351196.4861.131.camel@perches.com>
On 03/06/15 18:06, Joe Perches wrote:
> On Wed, 2015-06-03 at 17:55 +0100, Julien Grall wrote:
>> rx->status is an int16_t, print it using %d rather than %u in order to
>> have a meaningful value when the field is negative.
> []
>> diff --git a/drivers/net/xen-netfront.c b/drivers/net/xen-netfront.c
> []
>> @@ -733,7 +733,7 @@ static int xennet_get_responses(struct netfront_queue *queue,
>> if (unlikely(rx->status < 0 ||
>> rx->offset + rx->status > PAGE_SIZE)) {
>> if (net_ratelimit())
>> - dev_warn(dev, "rx->offset: %x, size: %u\n",
>> + dev_warn(dev, "rx->offset: %x, size: %d\n",
>
> If you're going to do this, perhaps it'd be sensible to
> also change the %x to %#x or 0x%x so that people don't
> mistake offset without an [a-f] for decimal.
Good idea. I will resend a version of this series.
David, can I keep you Reviewed-by for this change?
--
Julien Grall
next prev parent reply other threads:[~2015-06-04 12:45 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-06-03 16:55 [PATCH v2 0/2] net/xen: Clean up Julien Grall
2015-06-03 16:55 ` [PATCH v2 1/2] net/xen-netfront: Correct printf format in xennet_get_responses Julien Grall
2015-06-03 17:06 ` Joe Perches
2015-06-04 12:45 ` Julien Grall [this message]
2015-06-04 12:46 ` David Vrabel
2015-06-04 12:52 ` [Xen-devel] " Julien Grall
2015-06-04 16:25 ` Joe Perches
2015-06-05 12:34 ` Julien Grall
2015-06-05 15:49 ` Joe Perches
2015-06-04 18:43 ` David Miller
2015-06-03 16:55 ` [PATCH v2 2/2] net/xen-netback: Remove unused code in xenvif_rx_action Julien Grall
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5570484C.8040201@citrix.com \
--to=julien.grall@citrix.com \
--cc=boris.ostrovsky@oracle.com \
--cc=david.vrabel@citrix.com \
--cc=ian.campbell@citrix.com \
--cc=joe@perches.com \
--cc=konrad.wilk@oracle.com \
--cc=linux-kernel@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=stefano.stabellini@eu.citrix.com \
--cc=xen-devel@lists.xenproject.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).