From: Toshiaki Makita <toshiaki.makita1@gmail.com>
To: Scott Feldman <sfeldma@gmail.com>
Cc: roopa <roopa@cumulusnetworks.com>,
"Jamal Hadi Salim" <jhs@mojatatu.com>,
"David Miller" <davem@davemloft.net>,
"Toshiaki Makita" <makita.toshiaki@lab.ntt.co.jp>,
Netdev <netdev@vger.kernel.org>, "Jiří Pírko" <jiri@resnulli.us>,
"simon.horman@netronome.com" <simon.horman@netronome.com>
Subject: Re: [PATCH net-next 5/5] rocker: remove support for legacy VLAN ndo ops
Date: Thu, 04 Jun 2015 23:35:22 +0900 [thread overview]
Message-ID: <5570622A.8000407@gmail.com> (raw)
In-Reply-To: <alpine.DEB.2.02.1506032249390.46554@rocker1.rocker.net>
On 15/06/04 (木) 15:05, Scott Feldman wrote:
> On Thu, 4 Jun 2015, Toshiaki Makita wrote:
>
>> Bridge's vlan_filtering is handled in master->op->foo(), not in
>> port->op->foo().
>> Can't we introduce another switchdev handler that performs MASTER
>> operation instead of calling SELF operation?
>>
>> br_afspec()
>> nbp_vlan_add()
>> netdev_switch_port_vlan_add()
>> rocker->ndo_switch_port_vlan_add() <- only used for MASTER operation
>>
>> I'm wondering why SELF operation (rocker->ndo_bridge_setlink()) does
>> what should be done in MASTER operation.
>
> Something like this:
This looks very close to what I'm suggesting, although I'm not sure if
we need switchdev_port_obj_add() to be exclusive with vlan_vid_add().
For rocker, keeping NETIF_F_HW_VLAN_[CTAG/STAG]_FILTER dropped makes
vlan_vid_add() essentially noop.
Toshiaki Makita
next prev parent reply other threads:[~2015-06-04 14:35 UTC|newest]
Thread overview: 25+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-06-01 18:39 [PATCH net-next 0/5] rocker: enable by default untagged VLAN support sfeldma
2015-06-01 18:39 ` [PATCH net-next 1/5] rocker: zero allocate ports array sfeldma
2015-06-01 18:39 ` [PATCH net-next 2/5] rocker: cleanup vlan table on error adding vlan sfeldma
2015-06-01 18:39 ` [PATCH net-next 3/5] rocker: install untagged VLAN (vid=0) support for each port sfeldma
2015-06-01 18:39 ` [PATCH net-next 4/5] rocker: install/remove router MAC for untagged VLAN when joining/leaving bridge sfeldma
2015-06-01 18:39 ` [PATCH net-next 5/5] rocker: remove support for legacy VLAN ndo ops sfeldma
2015-06-02 4:51 ` Toshiaki Makita
2015-06-02 5:24 ` David Miller
2015-06-02 6:47 ` Toshiaki Makita
2015-06-02 7:10 ` Scott Feldman
2015-06-02 11:43 ` Jamal Hadi Salim
2015-06-02 14:30 ` Scott Feldman
2015-06-02 16:58 ` roopa
2015-06-02 19:01 ` Scott Feldman
2015-06-03 15:43 ` Toshiaki Makita
2015-06-03 18:41 ` roopa
2015-06-04 15:04 ` Toshiaki Makita
2015-06-04 15:09 ` roopa
2015-06-04 6:05 ` Scott Feldman
2015-06-04 14:35 ` Toshiaki Makita [this message]
2015-06-03 15:44 ` roopa
2015-06-03 12:08 ` Jamal Hadi Salim
2015-06-11 13:00 ` Jamal Hadi Salim
2015-06-11 18:25 ` Scott Feldman
2015-06-02 0:01 ` [PATCH net-next 0/5] rocker: enable by default untagged VLAN support David Miller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5570622A.8000407@gmail.com \
--to=toshiaki.makita1@gmail.com \
--cc=davem@davemloft.net \
--cc=jhs@mojatatu.com \
--cc=jiri@resnulli.us \
--cc=makita.toshiaki@lab.ntt.co.jp \
--cc=netdev@vger.kernel.org \
--cc=roopa@cumulusnetworks.com \
--cc=sfeldma@gmail.com \
--cc=simon.horman@netronome.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).