public inbox for netdev@vger.kernel.org
 help / color / mirror / Atom feed
From: Jesper Dangaard Brouer <hawk@kernel.org>
To: Jakub Kicinski <kuba@kernel.org>
Cc: netdev@vger.kernel.org, kernel-team@cloudflare.com,
	"Jonas Köppeler" <j.koeppeler@tu-berlin.de>,
	"Breno Leitao" <leitao@debian.org>,
	"David S. Miller" <davem@davemloft.net>,
	"Eric Dumazet" <edumazet@google.com>,
	"Paolo Abeni" <pabeni@redhat.com>,
	"Simon Horman" <horms@kernel.org>,
	"Shuah Khan" <shuah@kernel.org>,
	linux-kernel@vger.kernel.org, linux-kselftest@vger.kernel.org
Subject: Re: [PATCH net-next v3 5/5] selftests: net: add veth BQL stress test
Date: Fri, 1 May 2026 09:03:53 +0200	[thread overview]
Message-ID: <5571f831-dccb-4cfe-a618-35eec53963d7@kernel.org> (raw)
In-Reply-To: <20260430190058.5b20b15a@kernel.org>



On 01/05/2026 04.00, Jakub Kicinski wrote:
> On Wed, 29 Apr 2026 19:20:32 +0200 hawk@kernel.org wrote:
>> A companion wrapper (veth_bql_test_virtme.sh) launches the test inside
>> a virtme-ng VM, with .config validation to prevent silent stalls.
>>
>> Usage:
>>    sudo ./veth_bql_test.sh [--duration 300] [--nrules 100]
>>                            [--qdisc sfq] [--qdisc-opts '...']
>>                            [--bql-disable] [--normal-napi]
>>                            [--qdisc-replace]
> 
> Not convinced we need to carry this in the tree.

I agree, I will drop the selftest in V4.

The selftest have been very useful during *development* phase.
The number of options also reveal that we (Jonas and I) have been using
this beyond a selftest. The veth_bql_test_virtme.sh wrapper have been a
huge help to accelerate test-based development cycles,  but it's not a
selftest component per say. This have caught actual bugs in our BQL/DQL
API usage, but all those BUGs are fixed in code.

It makes a lot of sense to avoid having to maintain this code in tree.
I can place it somewhere on GitHub, else it can be pulled from lore.

--Jesper

  reply	other threads:[~2026-05-01  7:03 UTC|newest]

Thread overview: 11+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-04-29 17:20 [PATCH net-next v3 0/5] veth: add Byte Queue Limits (BQL) support hawk
2026-04-29 17:20 ` [PATCH net-next v3 1/5] net: add dev->bql flag to allow BQL sysfs for IFF_NO_QUEUE devices hawk
2026-04-29 17:20 ` [PATCH net-next v3 2/5] veth: implement Byte Queue Limits (BQL) for latency reduction hawk
2026-04-29 17:20 ` [PATCH net-next v3 3/5] veth: add tx_timeout watchdog as BQL safety net hawk
2026-04-29 17:20 ` [PATCH net-next v3 4/5] net: sched: add timeout count to NETDEV WATCHDOG message hawk
2026-04-29 17:20 ` [PATCH net-next v3 5/5] selftests: net: add veth BQL stress test hawk
2026-05-01  2:00   ` Jakub Kicinski
2026-05-01  7:03     ` Jesper Dangaard Brouer [this message]
2026-05-01  8:42   ` Breno Leitao
2026-05-01  1:58 ` [PATCH net-next v3 0/5] veth: add Byte Queue Limits (BQL) support Jakub Kicinski
2026-05-01  7:28   ` Jesper Dangaard Brouer

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=5571f831-dccb-4cfe-a618-35eec53963d7@kernel.org \
    --to=hawk@kernel.org \
    --cc=davem@davemloft.net \
    --cc=edumazet@google.com \
    --cc=horms@kernel.org \
    --cc=j.koeppeler@tu-berlin.de \
    --cc=kernel-team@cloudflare.com \
    --cc=kuba@kernel.org \
    --cc=leitao@debian.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-kselftest@vger.kernel.org \
    --cc=netdev@vger.kernel.org \
    --cc=pabeni@redhat.com \
    --cc=shuah@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox