From mboxrd@z Thu Jan 1 00:00:00 1970 From: roopa Subject: Re: [PATCH WIP RFC 0/3] mpls: support for ler Date: Wed, 10 Jun 2015 00:13:11 -0700 Message-ID: <5577E387.4030206@cumulusnetworks.com> References: <1433341306-29288-1-git-send-email-roopa@cumulusnetworks.com> <20150605091441.GA11896@pox.localdomain> <5571AF28.8000009@cumulusnetworks.com> <5571BF90.2070304@brocade.com> <557260E0.9060500@cumulusnetworks.com> <20150608123302.GA3634@pox.localdomain> <5575B207.4040900@cumulusnetworks.com> <20150608225843.GA4602@pox.localdomain> Mime-Version: 1.0 Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit Cc: Robert Shearman , ebiederm@xmission.com, netdev@vger.kernel.org, Vivek Venkatraman To: Thomas Graf Return-path: Received: from mail-qk0-f170.google.com ([209.85.220.170]:34405 "EHLO mail-qk0-f170.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753191AbbFJHNN (ORCPT ); Wed, 10 Jun 2015 03:13:13 -0400 Received: by qkoo18 with SMTP id o18so21144774qko.1 for ; Wed, 10 Jun 2015 00:13:12 -0700 (PDT) In-Reply-To: <20150608225843.GA4602@pox.localdomain> Sender: netdev-owner@vger.kernel.org List-ID: On 6/8/15, 3:58 PM, Thomas Graf wrote: > I'll immediately ACK any series that supports both models and rebase > my patches on top of it. I think we are on the right track overall. > >> I am trying to get my code on github to collaborate better. Stay tuned >> (hopefully end of day today). > Robert/Thomas, All my changes are in the below repo under the 'mpls' branch. https://github.com/CumulusNetworks/net-next https://github.com/CumulusNetworks/iproute2 The last iproute2 commit has a sample usage. The commits pushed to this tree do not contain support for the following yet (but working on it): a) tunnel routes to work with tunnel RTA_OIF and a non-tunnel RTA_OIF: The current commits in the tree assume a non-tunnel RTA_OIF. If the tunnel driver has registered a dst_output func, dst_output is set to the tunnel dst output handler in the receive route lookup path which in turn does the encap and xmits. Thomas had last suggested using a flag to skip the dst output handler re-direction for cases where RTA_OIF is a special tunnel netdev and the tunnel driver xmit function can do the encap. My current thinking is to pass the oif to the encap parse handler and the handler can set the flag on the tunnel state. And this flag can then be used to skip the dst_output re-direction. This change should be trivial will fix it soon. b) make RTA_OIF optional and do a fib lookup. keep your suggestions/feedback coming... thanks, Roopa