Re: [PATCH net-next] switchdev: fix BUG when port driver doesn't support set attr op

[David Ahern <dsahern@gmail.com>]

On 6/10/15 2:56 PM, sfeldma@gmail.com wrote:
> From: Scott Feldman <sfeldma@gmail.com>
>
> Fix a BUG() where CONFIG_NET_SWITCHDEV is set but the driver for a bridged
> port does not support switchdec_port_attr_set op.  Don't BUG() if
> -EOPNOTSUPP is returned.
>
> Signed-off-by: Scott Feldman <sfeldma@gmail.com>
> Reported-by: Brenden Blanco <bblanco@plumgrid.com>
> ---
>   net/switchdev/switchdev.c |    2 +-
>   1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/net/switchdev/switchdev.c b/net/switchdev/switchdev.c
> index e008057..99bced4 100644
> --- a/net/switchdev/switchdev.c
> +++ b/net/switchdev/switchdev.c
> @@ -103,7 +103,7 @@ static void switchdev_port_attr_set_work(struct work_struct *work)
>
>   	rtnl_lock();
>   	err = switchdev_port_attr_set(asw->dev, &asw->attr);
> -	BUG_ON(err);
> +	BUG_ON(err && err != -EOPNOTSUPP);
>   	rtnl_unlock();
>
>   	dev_put(asw->dev);
>

Should that be WARN_ON instead of BUG_ON?