From: David Ahern <dsahern@gmail.com>
To: Scott Feldman <sfeldma@gmail.com>
Cc: Netdev <netdev@vger.kernel.org>, "Jiří Pírko" <jiri@resnulli.us>,
"Brenden Blanco" <bblanco@plumgrid.com>
Subject: Re: [PATCH net-next] switchdev: fix BUG when port driver doesn't support set attr op
Date: Wed, 10 Jun 2015 15:51:28 -0600 [thread overview]
Message-ID: <5578B160.1070501@gmail.com> (raw)
In-Reply-To: <CAE4R7bD2RLa9D1_JnGr4RUMYHWMa-kQab=1ihN3YMkJgLqFViw@mail.gmail.com>
On 6/10/15 3:47 PM, Scott Feldman wrote:
>> Should that be WARN_ON instead of BUG_ON?
>
> I think I had it as WARN when we were working on the initial patches,
> but we changed it to BUG_ON because we should only get an error here
> if the driver screwed something up between PREPARE phase and COMMIT
> phase, so it should be considered a driver bug which needs fixing.
>
Linus rants from time to time about the prolific use of BUG_ON. e.g.,
https://lkml.org/lkml/2015/4/28/528
'BUG_ON() is for things where our internal data structures are so
corrupted that we don't know what to do, and there's no way to continue.
Not for "I want to sprinkle these things around and this should not
happen".'
David
next prev parent reply other threads:[~2015-06-10 21:51 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-06-10 20:56 [PATCH net-next] switchdev: fix BUG when port driver doesn't support set attr op sfeldma
2015-06-10 21:13 ` Andy Gospodarek
2015-06-10 21:25 ` David Ahern
2015-06-10 21:47 ` Scott Feldman
2015-06-10 21:51 ` David Ahern [this message]
2015-06-10 22:00 ` Scott Feldman
2015-06-11 6:16 ` Jiri Pirko
2015-06-11 15:03 ` Scott Feldman
2015-06-11 15:34 ` Jiri Pirko
2015-06-11 7:06 ` David Miller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5578B160.1070501@gmail.com \
--to=dsahern@gmail.com \
--cc=bblanco@plumgrid.com \
--cc=jiri@resnulli.us \
--cc=netdev@vger.kernel.org \
--cc=sfeldma@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox