From mboxrd@z Thu Jan 1 00:00:00 1970 From: Ivan Vecera Subject: Re: [PATCH net-next 19/19] bna: use netdev_* and dev_* instead of printk and pr_* Date: Thu, 11 Jun 2015 11:43:08 +0200 Message-ID: <5579582C.1050400@redhat.com> References: <1433954605-22813-1-git-send-email-ivecera@redhat.com> <1433954605-22813-20-git-send-email-ivecera@redhat.com> <1433968190.32331.32.camel@perches.com> Mime-Version: 1.0 Content-Type: text/plain; charset=windows-1252; format=flowed Content-Transfer-Encoding: 7bit Cc: netdev@vger.kernel.org, rasesh.mody@qlogic.com To: Joe Perches Return-path: Received: from mx1.redhat.com ([209.132.183.28]:33593 "EHLO mx1.redhat.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751404AbbFKJml (ORCPT ); Thu, 11 Jun 2015 05:42:41 -0400 In-Reply-To: <1433968190.32331.32.camel@perches.com> Sender: netdev-owner@vger.kernel.org List-ID: On 06/10/2015 10:29 PM, Joe Perches wrote: > On Wed, 2015-06-10 at 18:43 +0200, Ivan Vecera wrote: >> Signed-off-by: Ivan Vecera > > There should be some indication a few messages have > been deleted in the commit log and a reason why too. > >> diff --git a/drivers/net/ethernet/brocade/bna/bnad.c b/drivers/net/ethernet/brocade/bna/bnad.c > [] >> @@ -965,10 +964,6 @@ bnad_cb_ethport_link_status(struct bnad *bnad, >> /* >> * Force an immediate >> * Transmit Schedule */ >> - printk(KERN_INFO "bna: %s %d " >> - "TXQ_STARTED\n", >> - bnad->netdev->name, >> - txq_id); > > [] > >> @@ -1057,8 +1051,6 @@ bnad_cb_tx_stall(struct bnad *bnad, struct bna_tx *tx) >> txq_id = tcb->id; >> clear_bit(BNAD_TXQ_TX_STARTED, &tcb->flags); >> netif_stop_subqueue(bnad->netdev, txq_id); >> - printk(KERN_INFO "bna: %s %d TXQ_STOPPED\n", >> - bnad->netdev->name, txq_id); > > etc... > I'm sorry I have removed them as logging noise. IMHO it is not necessary to log when .probe() and .remove() are called or when TxQ is started or stopped. Ivan