From: Florian Fainelli <f.fainelli@gmail.com>
To: Guenter Roeck <linux@roeck-us.net>, Andrew Lunn <andrew@lunn.ch>,
David Miller <davem@davemloft.net>
Cc: Cory Tusar <cory.tusar@pid1solutions.com>,
netdev <netdev@vger.kernel.org>
Subject: Re: [PATCH 3/3] net: dsa: Allow configuration of CPU & DSA port speeds/duplex
Date: Mon, 15 Jun 2015 10:32:50 -0700 [thread overview]
Message-ID: <557F0C42.1040007@gmail.com> (raw)
In-Reply-To: <557B2525.7080401@roeck-us.net>
On 12/06/15 11:29, Guenter Roeck wrote:
[snip]
static int dsa_switch_setup_one(struct dsa_switch *ds, struct
>>> device *parent)
>>> {
>>> struct dsa_switch_driver *drv = ds->drv;
>>> @@ -204,6 +234,7 @@ static int dsa_switch_setup_one(struct dsa_switch
>>> *ds, struct device *parent)
>>> }
>>> dst->cpu_switch = index;
>>> dst->cpu_port = i;
>>> + ds->cpu_port_mask |= 1 << i;
>>
>> Same question as Guenter here, I assume this is because you plan on
>> having multiple CPU ports connected to the switch and this makes it
>> easier to deal with, is that right?
>>
>
> If so, should that be done in a separate patch set ?
I think it would be clearer that way, yes.
--
Florian
next prev parent reply other threads:[~2015-06-15 17:34 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-06-12 17:18 [PATCH 1/3] net: phy: Allow PHY devices to identify themselves as Ethernet switches, etc Andrew Lunn
2015-06-12 17:18 ` [PATCH 2/3] dsa: mv88e6xxx: Allow speed/duplex of port to be configured Andrew Lunn
2015-06-12 17:18 ` [PATCH 3/3] net: dsa: Allow configuration of CPU & DSA port speeds/duplex Andrew Lunn
2015-06-12 18:03 ` Guenter Roeck
2015-06-12 18:14 ` Florian Fainelli
2015-06-12 18:29 ` Guenter Roeck
2015-06-15 17:32 ` Florian Fainelli [this message]
2015-06-12 18:38 ` Andrew Lunn
2015-06-15 17:35 ` Florian Fainelli
2015-06-17 18:09 ` Vivien Didelot
2015-06-18 1:11 ` Andrew Lunn
2015-06-19 15:05 ` Vivien Didelot
2015-06-19 15:05 ` Andrew Lunn
2015-06-19 15:48 ` Vivien Didelot
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=557F0C42.1040007@gmail.com \
--to=f.fainelli@gmail.com \
--cc=andrew@lunn.ch \
--cc=cory.tusar@pid1solutions.com \
--cc=davem@davemloft.net \
--cc=linux@roeck-us.net \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).