From: Eric Dumazet <eric.dumazet@gmail.com>
To: Hangbin Liu <liuhangbin@gmail.com>, netdev@vger.kernel.org
Cc: Eric Dumazet <edumazet@google.com>,
"David S . Miller" <davem@davemloft.net>,
Jiri Benc <jbenc@redhat.com>
Subject: Re: [PATCH net] tcp: switch snprintf to scnprintf
Date: Thu, 14 Nov 2019 06:28:35 -0800 [thread overview]
Message-ID: <557b2545-3b3c-63a9-580c-270a0a103b2e@gmail.com> (raw)
In-Reply-To: <20191114102831.23753-1-liuhangbin@gmail.com>
On 11/14/19 2:28 AM, Hangbin Liu wrote:
> snprintf returns the number of chars that would be written, not number
> of chars that were actually written. As such, 'offs' may get larger than
> 'tbl.maxlen', causing the 'tbl.maxlen - offs' being < 0, and since the
> parameter is size_t, it would overflow.
>
> Currently, the buffer is still enough, but for future design, use scnprintf
> would be safer.
>
Why is it targeting net tree ?
How have you checked that it was actually safer ?
This looks unnecessary code churn to me, and it might hide an error in the future.
We need to properly size the output buffers before using them,
we can not afford truncating silently the output.
next prev parent reply other threads:[~2019-11-14 14:28 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-11-14 10:28 [PATCH net] tcp: switch snprintf to scnprintf Hangbin Liu
2019-11-14 14:28 ` Eric Dumazet [this message]
2019-11-15 2:41 ` Hangbin Liu
2019-11-15 9:54 ` Jiri Benc
2019-11-19 1:53 ` Hangbin Liu
2019-11-19 3:48 ` Eric Dumazet
2019-11-19 13:40 ` Hangbin Liu
2019-11-19 17:17 ` Eric Dumazet
2019-11-20 8:38 ` [PATCHv2 net-next] tcp: warn if offset reach the maxlen limit when using snprintf Hangbin Liu
2019-11-21 6:23 ` David Miller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=557b2545-3b3c-63a9-580c-270a0a103b2e@gmail.com \
--to=eric.dumazet@gmail.com \
--cc=davem@davemloft.net \
--cc=edumazet@google.com \
--cc=jbenc@redhat.com \
--cc=liuhangbin@gmail.com \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).