From: SF Markus Elfring <elfring@users.sourceforge.net>
To: Stefan Hajnoczi <stefanha@gmail.com>,
kvm@vger.kernel.org, netdev@vger.kernel.org,
virtualization@lists.linux-foundation.org,
kernel-janitors@vger.kernel.org
Cc: Jason Wang <jasowang@redhat.com>,
"Michael S. Tsirkin" <mst@redhat.com>,
LKML <linux-kernel@vger.kernel.org>,
Wolfram Sang <wsa@the-dreams.de>
Subject: Re: [PATCH 2/2] vhost/scsi: Delete error messages for failed memory allocations in five functions
Date: Mon, 22 May 2017 12:50:39 +0200 [thread overview]
Message-ID: <557bdff4-6dc2-756d-0d59-9f688ef11f0a@users.sourceforge.net> (raw)
In-Reply-To: <20170522094320.GE12205@stefanha-x1.localdomain>
>> Link: http://events.linuxfoundation.org/sites/events/files/slides/LCJ16-Refactor_Strings-WSang_0.pdf
>
> Please include an actual explanation for this change instead of linking
> to slides.
Do you care for a bit of code size reduction by removal of questionable
error messages?
> Why are you trying to get rid of memory allocation failure messages?
Do you find information from a Linux allocation failure report sufficient
for any function implementations here?
>> +++ b/drivers/vhost/scsi.c
>> @@ -417,5 +417,4 @@ vhost_scsi_allocate_evt(struct vhost_scsi *vs,
>> if (!evt) {
>> - vq_err(vq, "Failed to allocate vhost_scsi_evt\n");
>
> #define vq_err(vq, fmt, ...) do { \
> pr_debug(pr_fmt(fmt), ##__VA_ARGS__); \
> if ((vq)->error_ctx) \
> eventfd_signal((vq)->error_ctx, 1);\
> } while (0)
>
> You silently dropped the eventfd_signal() call.
Do you prefer to preserve this special error handling then?
Regards,
Markus
next prev parent reply other threads:[~2017-05-22 10:50 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-05-20 14:30 [PATCH 0/2] vhost/scsi: Adjustments for five function implementations SF Markus Elfring
2017-05-20 14:31 ` [PATCH 1/2] vhost/scsi: Improve a size determination in four functions SF Markus Elfring
2017-05-22 9:37 ` Stefan Hajnoczi
2017-05-20 14:32 ` [PATCH 2/2] vhost/scsi: Delete error messages for failed memory allocations in five functions SF Markus Elfring
2017-05-22 9:43 ` Stefan Hajnoczi
2017-05-22 10:50 ` SF Markus Elfring [this message]
2017-05-22 11:23 ` Stefan Hajnoczi
2017-05-22 11:34 ` SF Markus Elfring
2017-05-22 14:09 ` Stefan Hajnoczi
2017-05-22 14:21 ` SF Markus Elfring
2017-05-22 12:38 ` [PATCH 2/2] " Dan Carpenter
2017-05-22 14:08 ` Stefan Hajnoczi
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=557bdff4-6dc2-756d-0d59-9f688ef11f0a@users.sourceforge.net \
--to=elfring@users.sourceforge.net \
--cc=jasowang@redhat.com \
--cc=kernel-janitors@vger.kernel.org \
--cc=kvm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mst@redhat.com \
--cc=netdev@vger.kernel.org \
--cc=stefanha@gmail.com \
--cc=virtualization@lists.linux-foundation.org \
--cc=wsa@the-dreams.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).