From: roopa <roopa@cumulusnetworks.com>
To: Alexander Duyck <alexander.h.duyck@redhat.com>
Cc: Alexander Duyck <alexander.duyck@gmail.com>,
Scott Feldman <sfeldma@gmail.com>,
"David S. Miller" <davem@davemloft.net>,
Netdev <netdev@vger.kernel.org>
Subject: Re: [PATCH net] ipv4: include NLM_F_APPEND flag in append route notifications
Date: Wed, 17 Jun 2015 11:07:25 -0700 [thread overview]
Message-ID: <5581B75D.6020105@cumulusnetworks.com> (raw)
In-Reply-To: <5581AF03.8010501@redhat.com>
On 6/17/15, 10:31 AM, Alexander Duyck wrote:
>
> I'd say go with something closer to the original patch, but flip the
> logic like you have here, and lose the "|=" in favor of an "=" since
> you are either sending a message with 0 or NLM_F_APPEND.
>
> Anyway that is just my $.02.
agreed,
thanks alex, v2 posted..
prev parent reply other threads:[~2015-06-17 18:07 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-06-16 16:11 [PATCH net] ipv4: include NLM_F_APPEND flag in append route notifications Roopa Prabhu
2015-06-16 16:14 ` roopa
2015-06-17 7:50 ` Scott Feldman
2015-06-17 14:50 ` roopa
2015-06-17 15:35 ` Alexander Duyck
2015-06-17 16:20 ` roopa
2015-06-17 17:31 ` Alexander Duyck
2015-06-17 18:07 ` roopa [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5581B75D.6020105@cumulusnetworks.com \
--to=roopa@cumulusnetworks.com \
--cc=alexander.duyck@gmail.com \
--cc=alexander.h.duyck@redhat.com \
--cc=davem@davemloft.net \
--cc=netdev@vger.kernel.org \
--cc=sfeldma@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).