netdev.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Robert Shearman <rshearma@brocade.com>
To: roopa <roopa@cumulusnetworks.com>
Cc: <ebiederm@xmission.com>, <tgraf@suug.ch>, <davem@davemloft.net>,
	<netdev@vger.kernel.org>
Subject: Re: [PATCH net-next RFC v2 1/3] lwt: infrastructure to support light weight tunnels
Date: Fri, 19 Jun 2015 19:39:07 +0100	[thread overview]
Message-ID: <558461CB.3020408@brocade.com> (raw)
In-Reply-To: <5584609C.5020802@cumulusnetworks.com>

On 19/06/15 19:34, roopa wrote:
> On 6/19/15, 10:25 AM, Robert Shearman wrote:
>> n 19/06/15 16:14, roopa wrote:
>>> Today lwtunnel_skb_lwstate is called from lwtunnel_output which is only
>>> called from ipv4 code.
>>> And my ipv6 variant code was supposed to have a 6 suffix. something like
>>> lwtunnel_output6.
>>> Or to be more explicit i will probably have variants of the output and
>>> skb handling functions like,
>>> lwtunnel_output_ipv4 and lwtunnel_output_ipv6.
>>
>> Do you intend for these functions to be used by netdevices to support
>> the vxlan use case?
>>
>> If so, then how will the netdevice know which one of the two to call?
>> Will there have to be a netdevice for ipv4 and a netdevice for ipv6?
>>
>> If not, could you outline how you intend for it to be implemented?
>
> In the netdevice case, this output function is not called atall. It
> should just follow the existing netdevice the route is pointing to.

Sorry for not being clear, but I meant that there would have to be 
lwtunnel_skb_lwstate functions for ipv4 and ipv6 to match the output 
functions. So in the vxlan use case where it's using a netdevice, how 
would it determine which one to call?

Thanks,
Rob

  reply	other threads:[~2015-06-19 18:39 UTC|newest]

Thread overview: 14+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-06-19  4:49 [PATCH net-next RFC v2 1/3] lwt: infrastructure to support light weight tunnels Roopa Prabhu
2015-06-19 14:43 ` Robert Shearman
2015-06-19 15:14   ` roopa
2015-06-19 17:25     ` Robert Shearman
2015-06-19 18:34       ` roopa
2015-06-19 18:39         ` Robert Shearman [this message]
2015-06-20 14:27           ` roopa
2015-06-21 20:40             ` Thomas Graf
2015-06-22  2:48               ` roopa
2015-06-20 16:38 ` Nikolay Aleksandrov
2015-06-22  2:05   ` roopa
2015-06-21 20:32 ` Thomas Graf
2015-06-22  2:47   ` roopa
2015-07-03  9:49 ` Thomas Graf

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=558461CB.3020408@brocade.com \
    --to=rshearma@brocade.com \
    --cc=davem@davemloft.net \
    --cc=ebiederm@xmission.com \
    --cc=netdev@vger.kernel.org \
    --cc=roopa@cumulusnetworks.com \
    --cc=tgraf@suug.ch \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).