From mboxrd@z Thu Jan 1 00:00:00 1970 From: Oliver Hartkopp Subject: Re: displayed name changed in ip link show for bridge- and other interfaces Date: Sun, 21 Jun 2015 00:58:13 +0200 Message-ID: <5585F005.6060408@hartkopp.net> References: <201506141200.20435.ulrich.gemkow@ikr.uni-stuttgart.de> <557DCD0A.5040500@hartkopp.net> <557DD20E.4080005@hartkopp.net> <557E7D89.30301@6wind.com> <557E9728.7080208@6wind.com> <20150615085410.6628b5bb@urahara> <55805E6A.90805@hartkopp.net> <5581210D.5070901@6wind.com> Mime-Version: 1.0 Content-Type: text/plain; charset=windows-1252 Content-Transfer-Encoding: QUOTED-PRINTABLE Cc: Ulrich Gemkow , netdev@vger.kernel.org, David Miller To: nicolas.dichtel@6wind.com, Stephen Hemminger Return-path: Received: from mo4-p00-ob.smtp.rzone.de ([81.169.146.160]:42607 "EHLO mo4-p00-ob.smtp.rzone.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752234AbbFTXEh (ORCPT ); Sat, 20 Jun 2015 19:04:37 -0400 In-Reply-To: <5581210D.5070901@6wind.com> Sender: netdev-owner@vger.kernel.org List-ID: On 06/17/2015 09:26 AM, Nicolas Dichtel wrote: > Le 16/06/2015 19:35, Oliver Hartkopp a =E9crit : >> On 15.06.2015 17:54, Stephen Hemminger wrote: >>> On Mon, 15 Jun 2015 11:13:12 +0200 >>> Nicolas Dichtel wrote: >>> >>>> Theoretically, virtual interfaces should advertise an IFLA_LINK to= 0. >>>> I don't know what is the best fix: >>>> - patching iproute2 to avoid this '@NONE' >>>> - patching the kernel (see below). >>> >>> >>> Sorry this is an ABI change. The kernel has to go back >>> to doing the same thing as before. >>> >> >> Isn't this too late right now at 4.1-rc8 stage??? >> >> At least the patch suggested for br_device.c at >> >> http://marc.info/?l=3Dlinux-netdev&m=3D143435960111768&w=3D2 >> >> would been necessary in all networking drivers, right? >> >> I currently see this @NONE stuff with virtual CAN devices too. > Another solution is to revert e1622baf54df ("dev: set iflink to 0 for= virtual > interfaces") and add a ndo_get_iflink handler which returns 0 for all= virtual > interfaces that had this IFLA_LINK set to 0 before the series. > But it's not consistent between virtual interfaces. I have no good suggestion, as I don't know if this makes a difference f= or the ABI to finally make 'ip' omit the '@NONE' output. E.g. virtual CAN interfaces (vcan.c) now print this @NONE and they neve= r have a (physical?) link. So you probably have to deal with different virtual interfaces anyway, right? Regards, Oliver