Re: [PATCHv2 net-next] net: fec: Ensure clocks are enabled while using mdio bus

[Florian Fainelli <f.fainelli@gmail.com>]

Le 06/20/15 09:15, Andrew Lunn a écrit :
> When a switch is attached to the mdio bus, the mdio bus can be used
> while the interface is not open. If the IPG clock are not enabled,
> MDIO reads/writes will simply time out. So enable the clock before
> starting a transaction, and disable it afterwards. The CCF performs
> reference counting so the clock will only be disabled if there are no
> other users.
> 
> Signed-off-by: Andrew Lunn <andrew@lunn.ch>
> ---
> v2:
>   Only enable/disable the IPG clock.
> 
> drivers/net/ethernet/freescale/fec_main.c | 21 +++++++++++++++++++--
>  1 file changed, 19 insertions(+), 2 deletions(-)
> 
> diff --git a/drivers/net/ethernet/freescale/fec_main.c b/drivers/net/ethernet/freescale/fec_main.c
> index bf4cf3fbb5f2..2b8a043a573c 100644
> --- a/drivers/net/ethernet/freescale/fec_main.c
> +++ b/drivers/net/ethernet/freescale/fec_main.c
> @@ -65,6 +65,7 @@
>  
>  static void set_multicast_list(struct net_device *ndev);
>  static void fec_enet_itr_coal_init(struct net_device *ndev);
> +static int fec_enet_clk_enable(struct net_device *ndev, bool enable);

You do not seem to be using this, unrelated change?
-- 
Florian