From: Richard Weinberger <richard@nod.at>
To: Alexei Starovoitov <alexei.starovoitov@gmail.com>,
Nicolai Stange <nicstange@gmail.com>
Cc: "David S. Miller" <davem@davemloft.net>,
netdev@vger.kernel.org, linux-kernel@vger.kernel.org,
daniel@iogearbox.net
Subject: Re: [PATCH] lib: test_bpf: purge CPP register redefinitions
Date: Mon, 22 Jun 2015 08:52:55 +0200 [thread overview]
Message-ID: <5587B0C7.8090507@nod.at> (raw)
In-Reply-To: <20150622060523.GA16156@Alexeis-MacBook-Pro.local>
Am 22.06.2015 um 08:05 schrieb Alexei Starovoitov:
> to get rid of warning you proposing to do 1k line renames?!
> Just add:
> +#undef R8
> +#undef R9
> +#undef R10
> #define R0 BPF_REG_0
This would be also just another hack.
> Though I think the better fix woud be to clean up:
> arch/x86/include/uapi/asm/ptrace-abi.h
> What's the point of:
> #define R8 72
> from 'uapi' point of view?
To query cpu registers using ptrace(2).
> Look like kernel details that shouldn't be exposed in uapi.
These are not kernel details.
Actually the problem is the other way around.
UML is Linux ported to it's own userspace ABI.
Hence, the arch/um and arch/x86/um use uapi header files.
Maybe we can rework UML's header files such that
no uapi header pollutes the kernel namespace.
That said, lib/test_bpf.c should still not use
defines like R8 as such symbols are very generic.
Thanks,
//richard
next prev parent reply other threads:[~2015-06-22 6:52 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-06-21 19:41 [PATCH] lib: test_bpf: purge CPP register redefinitions Nicolai Stange
2015-06-22 6:05 ` Alexei Starovoitov
2015-06-22 6:52 ` Richard Weinberger [this message]
2015-06-22 7:10 ` Richard Weinberger
2015-06-22 13:47 ` Nicolai Stange
2015-06-23 13:47 ` David Miller
2015-06-23 13:47 ` David Miller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5587B0C7.8090507@nod.at \
--to=richard@nod.at \
--cc=alexei.starovoitov@gmail.com \
--cc=daniel@iogearbox.net \
--cc=davem@davemloft.net \
--cc=linux-kernel@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=nicstange@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).