From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mx3.molgen.mpg.de (mx3.molgen.mpg.de [141.14.17.11]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 742F42C3248; Wed, 29 Apr 2026 11:02:38 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=141.14.17.11 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1777460561; cv=none; b=asK+tO9oXH22glskekYvEvurhMuZz2xUsAXHPvdD+VlPCTT/dovHGqMWiASW77WppjnrDsraOrgvxJ5paDS5D0psmCbctiIbaIQNoInAgPcTN2FswtHAs8MJmZWGoBOhlxq9+bMpU4cz/t42eURnL7C/54zkBQ+bFS4tjLWNn2A= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1777460561; c=relaxed/simple; bh=oEhLKJekH4gbEUFZ3JIXTDUoA60DTJ50Ve6pKGdF8vU=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=nnEPVU5CN66MckZTb/0xwTq9ZzIjguHJ49EjxHAijg6wfE5sL1yyf11nNgs3uk2sfqidNfMQOWVTxMkemjh9ihNDpybBdPiQ9E2dke8dNhamy/ppcaxJ79OJxRkfCUsb4At8GfdwlytR828ZPoXNA/A0qk79UyEWf2OBs5s3Mww= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=molgen.mpg.de; spf=pass smtp.mailfrom=molgen.mpg.de; arc=none smtp.client-ip=141.14.17.11 Authentication-Results: smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=molgen.mpg.de Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=molgen.mpg.de Received: from [141.14.220.42] (g42.guest.molgen.mpg.de [141.14.220.42]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) (Authenticated sender: pmenzel) by mx.molgen.mpg.de (Postfix) with ESMTPSA id 048184C4431148; Wed, 29 Apr 2026 13:02:01 +0200 (CEST) Message-ID: <558971b7-caea-471a-8fe2-73ba6cc0790a@molgen.mpg.de> Date: Wed, 29 Apr 2026 13:02:00 +0200 Precedence: bulk X-Mailing-List: netdev@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [Intel-wired-lan] [PATCH] i40e: Fix i40e_debug() to use struct i40e_hw argument To: Mohamed Khalfella Cc: Tony Nguyen , Przemek Kitszel , "David S . Miller" , Eric Dumazet , Jakub Kicinski , Paolo Abeni , intel-wired-lan@lists.osuosl.org, netdev@vger.kernel.org, linux-kernel@vger.kernel.org References: <20260428181450.2622899-1-mkhalfella@purestorage.com> Content-Language: en-US From: Paul Menzel In-Reply-To: <20260428181450.2622899-1-mkhalfella@purestorage.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit Dear Mohamed, Thank you for your patch. Am 28.04.26 um 20:14 schrieb Mohamed Khalfella: > i40e_debug() macro takes struct i40e_hw *h as first argument. But the > macro body uses hw instead of h. This has been working so far because hw > happen to be the name of the variable in the context where the marco is marco → ma*cr*o > expanded. Fix the macro to use the passed argument. I’d add a Fixes: tag, but the maintainers might have more input. > Signed-off-by: Mohamed Khalfella > --- > drivers/net/ethernet/intel/i40e/i40e_debug.h | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/net/ethernet/intel/i40e/i40e_debug.h b/drivers/net/ethernet/intel/i40e/i40e_debug.h > index e9871dfb32bd..01fd70db9086 100644 > --- a/drivers/net/ethernet/intel/i40e/i40e_debug.h > +++ b/drivers/net/ethernet/intel/i40e/i40e_debug.h > @@ -42,7 +42,7 @@ struct device *i40e_hw_to_dev(struct i40e_hw *hw); > #define i40e_debug(h, m, s, ...) \ > do { \ > if (((m) & (h)->debug_mask)) \ > - dev_info(i40e_hw_to_dev(hw), s, ##__VA_ARGS__); \ > + dev_info(i40e_hw_to_dev(h), s, ##__VA_ARGS__); \ > } while (0) > > #endif /* _I40E_DEBUG_H_ */ Reviewed-by: Paul Menzel Kind regards, Paul PS: gemini/gemini-3.1-pro-preview embargoed it’s review until the evening [1]. [1]: https://sashiko.dev/#/patchset/20260428181450.2622899-1-mkhalfella%40purestorage.com