From mboxrd@z Thu Jan 1 00:00:00 1970 From: Toshiaki Makita Subject: Re: [PATCH net-next] bridge: vlan: flush the dynamically learned entries on port vlan delete Date: Wed, 24 Jun 2015 00:02:33 +0900 Message-ID: <55897509.8010205@gmail.com> References: <1435062496-14596-1-git-send-email-nikolay@cumulusnetworks.com> Mime-Version: 1.0 Content-Type: text/plain; charset=iso-2022-jp Content-Transfer-Encoding: 7bit Cc: vyasevich@gmail.com, bridge@lists.linux-foundation.org, davem@davemloft.net To: Nikolay Aleksandrov , netdev@vger.kernel.org Return-path: In-Reply-To: <1435062496-14596-1-git-send-email-nikolay@cumulusnetworks.com> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: bridge-bounces@lists.linux-foundation.org Errors-To: bridge-bounces@lists.linux-foundation.org List-Id: netdev.vger.kernel.org On 15/06/23 (火) 21:28, Nikolay Aleksandrov wrote: > Add a new argument to br_fdb_delete_by_port which allows to specify a > vid to match when flushing entries and use it in nbp_vlan_delete() to > flush the dynamically learned entries of the vlan/port pair when removing > a vlan from a port. Before this patch only the local mac was being > removed and the dynamically learned ones were left to expire. > Note that the do_all argument is still respected and if specified, the > vid will be ignored. > > Signed-off-by: Nikolay Aleksandrov > --- > note: There are 2 warnings, the C99 comment was already there and the 81 > char line is the prototype and I think it looks better this way. > One unclear thing is about vid 0, I see that it can be passed to > nbp_vlan_(add|delete) although the comment says it shouldn't. nbp_vlan_add() should not be called with vid 0 because vid 0 of fdb entries is internally used when vlan_filtering is disabled, and such entries are exposed to userspace as those without any vlan id. bridge's vlan_filtering is respecting 802.1Q-2011 spec, which says vid 0 cannot be used as a normal vlan id. If vlan 0 can be added, it should be a bug. Toshiaki Makita