netdev.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Alan Ott <alan@signal11.us>
To: Antonio Borneo <borneo.antonio@gmail.com>,
	Alexander Aring <alex.aring@gmail.com>,
	Varka Bhadram <varkabhadram@gmail.com>,
	linux-wpan@vger.kernel.org, netdev@vger.kernel.org
Cc: linux-kernel@vger.kernel.org
Subject: Re: [PATCH 4/6] net: ieee802154: Remove redundant spi driver bus initialization
Date: Tue, 23 Jun 2015 11:08:40 -0400	[thread overview]
Message-ID: <55897678.40907@signal11.us> (raw)
In-Reply-To: <1435071172-24542-1-git-send-email-borneo.antonio@gmail.com>

On 06/23/2015 10:52 AM, Antonio Borneo wrote:
> In ancient times it was necessary to manually initialize the bus
> field of an spi_driver to spi_bus_type. These days this is done in
> spi_register_driver(), so we can drop the manual assignment.
>
> Signed-off-by: Antonio Borneo <borneo.antonio@gmail.com>
> To: Alan Ott <alan@signal11.us>
> To: Alexander Aring <alex.aring@gmail.com>
> To: Varka Bhadram <varkabhadram@gmail.com>
> To: linux-wpan@vger.kernel.org
> To: netdev@vger.kernel.org
> Cc: linux-kernel@vger.kernel.org
> ---
>   drivers/net/ieee802154/cc2520.c   | 1 -
>   drivers/net/ieee802154/mrf24j40.c | 1 -
>   2 files changed, 2 deletions(-)
>
> diff --git a/drivers/net/ieee802154/cc2520.c b/drivers/net/ieee802154/cc2520.c
> index f833b8b..bd957f1 100644
> --- a/drivers/net/ieee802154/cc2520.c
> +++ b/drivers/net/ieee802154/cc2520.c
> @@ -1046,7 +1046,6 @@ MODULE_DEVICE_TABLE(of, cc2520_of_ids);
>   static struct spi_driver cc2520_driver = {
>   	.driver = {
>   		.name = "cc2520",
> -		.bus = &spi_bus_type,
>   		.owner = THIS_MODULE,
>   		.of_match_table = of_match_ptr(cc2520_of_ids),
>   	},
> diff --git a/drivers/net/ieee802154/mrf24j40.c b/drivers/net/ieee802154/mrf24j40.c
> index fba2dfd..bc8fb26 100644
> --- a/drivers/net/ieee802154/mrf24j40.c
> +++ b/drivers/net/ieee802154/mrf24j40.c
> @@ -812,7 +812,6 @@ MODULE_DEVICE_TABLE(spi, mrf24j40_ids);
>   static struct spi_driver mrf24j40_driver = {
>   	.driver = {
>   		.name = "mrf24j40",
> -		.bus = &spi_bus_type,
>   		.owner = THIS_MODULE,
>   	},
>   	.id_table = mrf24j40_ids,

Acked-by: Alan Ott <alan@signal11.us>

  parent reply	other threads:[~2015-06-23 15:08 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-06-23 14:45 [PATCH 0/6] Remove redundant spi driver bus initialization Antonio Borneo
2015-06-23 14:52 ` [PATCH 4/6] net: ieee802154: " Antonio Borneo
2015-06-23 15:06   ` Varka Bhadram
2015-06-23 15:08   ` Alan Ott [this message]
2015-07-13 17:29   ` Alexander Aring
2015-07-14  5:07   ` Marcel Holtmann
2015-06-23 14:53 ` [PATCH 5/6] wireless: cw1200: " Antonio Borneo
2015-07-21 13:44   ` [5/6] " Kalle Valo

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=55897678.40907@signal11.us \
    --to=alan@signal11.us \
    --cc=alex.aring@gmail.com \
    --cc=borneo.antonio@gmail.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-wpan@vger.kernel.org \
    --cc=netdev@vger.kernel.org \
    --cc=varkabhadram@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).