From: Or Gerlitz <ogerlitz@mellanox.com>
To: Eric Dumazet <eric.dumazet@gmail.com>
Cc: "David S. Miller" <davem@davemloft.net>, <netdev@vger.kernel.org>,
"Amir Vadai" <amirv@mellanox.com>, Ido Shamay <idos@mellanox.com>
Subject: Re: [PATCH net 3/4] net/mlx4_en: Fix wrong csum complete report when rxvlan offload is disabled
Date: Thu, 25 Jun 2015 09:36:11 +0300 [thread overview]
Message-ID: <558BA15B.3030106@mellanox.com> (raw)
In-Reply-To: <1435183281.4110.24.camel@edumazet-glaptop2.roam.corp.google.com>
On 6/25/2015 1:01 AM, Eric Dumazet wrote:
> On Wed, 2015-06-24 at 18:22 +0300, Or Gerlitz wrote:
>> From: Ido Shamay <idos@mellanox.com>
>>
>> + if (be32_to_cpu(cqe->vlan_my_qpn) & MLX4_CQE_VLAN_PRESENT_MASK &&
>> + !(dev_features & NETIF_F_HW_VLAN_CTAG_RX)) {
>> hw_checksum = get_fixed_vlan_csum(hw_checksum, hdr);
>> hdr += sizeof(struct vlan_hdr);
> This is faster to use
>
> if (cqe->vlan_my_qpn & cpu_to_be32(MLX4_CQE_VLAN_PRESENT_MASK) &&
>
>
>
sure, will fix that and re-spin the series
Or.
next prev parent reply other threads:[~2015-06-25 6:36 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-06-24 15:21 [PATCH net 0/4] mlx4 driver fixes, June 24, 2015 Or Gerlitz
2015-06-24 15:22 ` [PATCH net 1/4] net/mlx4_en: Release TX QP when destroying TX ring Or Gerlitz
2015-06-24 15:22 ` [PATCH net 2/4] net/mlx4_en: Wake TX queues only when there's enough room Or Gerlitz
2015-06-24 15:22 ` [PATCH net 3/4] net/mlx4_en: Fix wrong csum complete report when rxvlan offload is disabled Or Gerlitz
2015-06-24 22:01 ` Eric Dumazet
2015-06-25 6:36 ` Or Gerlitz [this message]
2015-06-24 15:22 ` [PATCH net 4/4] mlx4: Disable HA for SRIOV PF RoCE devices Or Gerlitz
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=558BA15B.3030106@mellanox.com \
--to=ogerlitz@mellanox.com \
--cc=amirv@mellanox.com \
--cc=davem@davemloft.net \
--cc=eric.dumazet@gmail.com \
--cc=idos@mellanox.com \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).