* [PATCH] net: via: VIA_RHINE and VIA_VELOCITY should depend on HAS_DMA
@ 2015-06-26 12:08 Geert Uytterhoeven
2015-06-26 13:21 ` Sergei Shtylyov
2015-06-29 3:21 ` David Miller
0 siblings, 2 replies; 4+ messages in thread
From: Geert Uytterhoeven @ 2015-06-26 12:08 UTC (permalink / raw)
To: David S. Miller, Antonio Borneo; +Cc: netdev, linux-kernel, Geert Uytterhoeven
If NO_DMA=y:
ERROR: "dma_sync_single_for_cpu" [drivers/net/ethernet/via/via-rhine.ko] undefined!
ERROR: "dma_set_mask" [drivers/net/ethernet/via/via-rhine.ko] undefined!
ERROR: "dma_mapping_error" [drivers/net/ethernet/via/via-rhine.ko] undefined!
ERROR: "dma_map_single" [drivers/net/ethernet/via/via-rhine.ko] undefined!
ERROR: "dma_alloc_coherent" [drivers/net/ethernet/via/via-rhine.ko] undefined!
ERROR: "dma_free_coherent" [drivers/net/ethernet/via/via-rhine.ko] undefined!
ERROR: "dma_unmap_single" [drivers/net/ethernet/via/via-rhine.ko] undefined!
ERROR: "dma_map_page" [drivers/net/ethernet/via/via-velocity.ko] undefined!
ERROR: "dma_sync_single_for_cpu" [drivers/net/ethernet/via/via-velocity.ko] undefined!
ERROR: "dma_free_coherent" [drivers/net/ethernet/via/via-velocity.ko] undefined!
ERROR: "dma_unmap_single" [drivers/net/ethernet/via/via-velocity.ko] undefined!
ERROR: "dma_map_single" [drivers/net/ethernet/via/via-velocity.ko] undefined!
ERROR: "dma_alloc_coherent" [drivers/net/ethernet/via/via-velocity.ko] undefined!
Before, the symbols depended implicitly on HAS_DMA through PCI or
USE_OF. Add explicit dependencies on HAS_DMA to fix this.
Fixes: commit b7d3282a245f4428 ("net: via/Kconfig: replace USE_OF with OF_???")
Signed-off-by: Geert Uytterhoeven <geert@linux-m68k.org>
---
drivers/net/ethernet/via/Kconfig | 2 ++
1 file changed, 2 insertions(+)
diff --git a/drivers/net/ethernet/via/Kconfig b/drivers/net/ethernet/via/Kconfig
index 8b0b1d6aca72c4a3..2f1264b882b9555f 100644
--- a/drivers/net/ethernet/via/Kconfig
+++ b/drivers/net/ethernet/via/Kconfig
@@ -18,6 +18,7 @@ if NET_VENDOR_VIA
config VIA_RHINE
tristate "VIA Rhine support"
depends on (PCI || OF_IRQ)
+ depends on HAS_DMA
select CRC32
select MII
---help---
@@ -42,6 +43,7 @@ config VIA_RHINE_MMIO
config VIA_VELOCITY
tristate "VIA Velocity support"
depends on (PCI || (OF_ADDRESS && OF_IRQ))
+ depends on HAS_DMA
select CRC32
select CRC_CCITT
select MII
--
1.9.1
^ permalink raw reply related [flat|nested] 4+ messages in thread* Re: [PATCH] net: via: VIA_RHINE and VIA_VELOCITY should depend on HAS_DMA
2015-06-26 12:08 [PATCH] net: via: VIA_RHINE and VIA_VELOCITY should depend on HAS_DMA Geert Uytterhoeven
@ 2015-06-26 13:21 ` Sergei Shtylyov
2015-06-27 6:38 ` Antonio Borneo
2015-06-29 3:21 ` David Miller
1 sibling, 1 reply; 4+ messages in thread
From: Sergei Shtylyov @ 2015-06-26 13:21 UTC (permalink / raw)
To: Geert Uytterhoeven, David S. Miller, Antonio Borneo; +Cc: netdev, linux-kernel
Hello.
On 6/26/2015 3:08 PM, Geert Uytterhoeven wrote:
> If NO_DMA=y:
> ERROR: "dma_sync_single_for_cpu" [drivers/net/ethernet/via/via-rhine.ko] undefined!
> ERROR: "dma_set_mask" [drivers/net/ethernet/via/via-rhine.ko] undefined!
> ERROR: "dma_mapping_error" [drivers/net/ethernet/via/via-rhine.ko] undefined!
> ERROR: "dma_map_single" [drivers/net/ethernet/via/via-rhine.ko] undefined!
> ERROR: "dma_alloc_coherent" [drivers/net/ethernet/via/via-rhine.ko] undefined!
> ERROR: "dma_free_coherent" [drivers/net/ethernet/via/via-rhine.ko] undefined!
> ERROR: "dma_unmap_single" [drivers/net/ethernet/via/via-rhine.ko] undefined!
> ERROR: "dma_map_page" [drivers/net/ethernet/via/via-velocity.ko] undefined!
> ERROR: "dma_sync_single_for_cpu" [drivers/net/ethernet/via/via-velocity.ko] undefined!
> ERROR: "dma_free_coherent" [drivers/net/ethernet/via/via-velocity.ko] undefined!
> ERROR: "dma_unmap_single" [drivers/net/ethernet/via/via-velocity.ko] undefined!
> ERROR: "dma_map_single" [drivers/net/ethernet/via/via-velocity.ko] undefined!
> ERROR: "dma_alloc_coherent" [drivers/net/ethernet/via/via-velocity.ko] undefined!
> Before, the symbols depended implicitly on HAS_DMA through PCI or
> USE_OF. Add explicit dependencies on HAS_DMA to fix this.
> Fixes: commit b7d3282a245f4428 ("net: via/Kconfig: replace USE_OF with OF_???")
Fixes: b7d3282a245f ("net: via/Kconfig: replace USE_OF with OF_???")
> Signed-off-by: Geert Uytterhoeven <geert@linux-m68k.org>
WBR, Sergei
^ permalink raw reply [flat|nested] 4+ messages in thread* Re: [PATCH] net: via: VIA_RHINE and VIA_VELOCITY should depend on HAS_DMA
2015-06-26 13:21 ` Sergei Shtylyov
@ 2015-06-27 6:38 ` Antonio Borneo
0 siblings, 0 replies; 4+ messages in thread
From: Antonio Borneo @ 2015-06-27 6:38 UTC (permalink / raw)
To: Sergei Shtylyov
Cc: Geert Uytterhoeven, David S. Miller, netdev,
linux-kernel@vger.kernel.org
On Fri, Jun 26, 2015 at 9:21 PM, Sergei Shtylyov
<sergei.shtylyov@cogentembedded.com> wrote:
> Hello.
>
> On 6/26/2015 3:08 PM, Geert Uytterhoeven wrote:
>
>> If NO_DMA=y:
>
>
>> ERROR: "dma_sync_single_for_cpu"
>> [drivers/net/ethernet/via/via-rhine.ko] undefined!
>> ERROR: "dma_set_mask" [drivers/net/ethernet/via/via-rhine.ko]
>> undefined!
>> ERROR: "dma_mapping_error" [drivers/net/ethernet/via/via-rhine.ko]
>> undefined!
>> ERROR: "dma_map_single" [drivers/net/ethernet/via/via-rhine.ko]
>> undefined!
>> ERROR: "dma_alloc_coherent" [drivers/net/ethernet/via/via-rhine.ko]
>> undefined!
>> ERROR: "dma_free_coherent" [drivers/net/ethernet/via/via-rhine.ko]
>> undefined!
>> ERROR: "dma_unmap_single" [drivers/net/ethernet/via/via-rhine.ko]
>> undefined!
>> ERROR: "dma_map_page" [drivers/net/ethernet/via/via-velocity.ko]
>> undefined!
>> ERROR: "dma_sync_single_for_cpu"
>> [drivers/net/ethernet/via/via-velocity.ko] undefined!
>> ERROR: "dma_free_coherent" [drivers/net/ethernet/via/via-velocity.ko]
>> undefined!
>> ERROR: "dma_unmap_single" [drivers/net/ethernet/via/via-velocity.ko]
>> undefined!
>> ERROR: "dma_map_single" [drivers/net/ethernet/via/via-velocity.ko]
>> undefined!
>> ERROR: "dma_alloc_coherent"
>> [drivers/net/ethernet/via/via-velocity.ko] undefined!
>
>
>> Before, the symbols depended implicitly on HAS_DMA through PCI or
>> USE_OF. Add explicit dependencies on HAS_DMA to fix this.
>
>
>> Fixes: commit b7d3282a245f4428 ("net: via/Kconfig: replace USE_OF with
>> OF_???")
>
>
> Fixes: b7d3282a245f ("net: via/Kconfig: replace USE_OF with OF_???")
>
>> Signed-off-by: Geert Uytterhoeven <geert@linux-m68k.org>
>
>
> WBR, Sergei
>
Yes, I can confirm it.
If HAS_DMA is not defined the build is broken.
Your patch fixes the issue.
Thanks,
Antonio
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH] net: via: VIA_RHINE and VIA_VELOCITY should depend on HAS_DMA
2015-06-26 12:08 [PATCH] net: via: VIA_RHINE and VIA_VELOCITY should depend on HAS_DMA Geert Uytterhoeven
2015-06-26 13:21 ` Sergei Shtylyov
@ 2015-06-29 3:21 ` David Miller
1 sibling, 0 replies; 4+ messages in thread
From: David Miller @ 2015-06-29 3:21 UTC (permalink / raw)
To: geert; +Cc: borneo.antonio, netdev, linux-kernel
From: Geert Uytterhoeven <geert@linux-m68k.org>
Date: Fri, 26 Jun 2015 14:08:22 +0200
> If NO_DMA=y:
...
> Before, the symbols depended implicitly on HAS_DMA through PCI or
> USE_OF. Add explicit dependencies on HAS_DMA to fix this.
>
> Fixes: commit b7d3282a245f4428 ("net: via/Kconfig: replace USE_OF with OF_???")
> Signed-off-by: Geert Uytterhoeven <geert@linux-m68k.org>
Applied, thanks Geert.
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2015-06-29 3:21 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2015-06-26 12:08 [PATCH] net: via: VIA_RHINE and VIA_VELOCITY should depend on HAS_DMA Geert Uytterhoeven
2015-06-26 13:21 ` Sergei Shtylyov
2015-06-27 6:38 ` Antonio Borneo
2015-06-29 3:21 ` David Miller
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).