* [PATCH] xen-netfront: Remove the meaningless code
@ 2015-06-26 23:17 Liang Li
2015-06-26 15:15 ` David Vrabel
0 siblings, 1 reply; 3+ messages in thread
From: Liang Li @ 2015-06-26 23:17 UTC (permalink / raw)
To: linux-kernel
Cc: netdev, xen-devel, konrad.wilk, boris.ostrovsky, david.vrabel,
andrew.bennieston, wei.liu2, davem, Liang Li
The function netif_set_real_num_tx_queues() will return -EINVAL if
the second parameter < 1, so call this function with the second
parameter set to 0 is meaningless.
Signed-off-by: Liang Li <liang.z.li@intel.com>
---
drivers/net/xen-netfront.c | 7 -------
1 file changed, 7 deletions(-)
diff --git a/drivers/net/xen-netfront.c b/drivers/net/xen-netfront.c
index 56d8afd..1807cd1 100644
--- a/drivers/net/xen-netfront.c
+++ b/drivers/net/xen-netfront.c
@@ -1245,10 +1245,6 @@ static struct net_device *xennet_create_dev(struct xenbus_device *dev)
np = netdev_priv(netdev);
np->xbdev = dev;
- /* No need to use rtnl_lock() before the call below as it
- * happens before register_netdev().
- */
- netif_set_real_num_tx_queues(netdev, 0);
np->queues = NULL;
err = -ENOMEM;
@@ -1900,9 +1896,6 @@ abort_transaction_no_dev_fatal:
xennet_disconnect_backend(info);
kfree(info->queues);
info->queues = NULL;
- rtnl_lock();
- netif_set_real_num_tx_queues(info->netdev, 0);
- rtnl_unlock();
out:
return err;
}
--
1.9.1
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [PATCH] xen-netfront: Remove the meaningless code
2015-06-26 23:17 [PATCH] xen-netfront: Remove the meaningless code Liang Li
@ 2015-06-26 15:15 ` David Vrabel
2015-06-28 23:49 ` David Miller
0 siblings, 1 reply; 3+ messages in thread
From: David Vrabel @ 2015-06-26 15:15 UTC (permalink / raw)
To: Liang Li, linux-kernel
Cc: netdev, xen-devel, konrad.wilk, boris.ostrovsky,
andrew.bennieston, wei.liu2, davem
On 27/06/15 00:17, Liang Li wrote:
> The function netif_set_real_num_tx_queues() will return -EINVAL if
> the second parameter < 1, so call this function with the second
> parameter set to 0 is meaningless.
Reviewed-by: David Vrabel <david.vrabel@citrix.com>
David
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH] xen-netfront: Remove the meaningless code
2015-06-26 15:15 ` David Vrabel
@ 2015-06-28 23:49 ` David Miller
0 siblings, 0 replies; 3+ messages in thread
From: David Miller @ 2015-06-28 23:49 UTC (permalink / raw)
To: david.vrabel
Cc: liang.z.li, linux-kernel, netdev, xen-devel, konrad.wilk,
boris.ostrovsky, andrew.bennieston, wei.liu2
From: David Vrabel <david.vrabel@citrix.com>
Date: Fri, 26 Jun 2015 16:15:18 +0100
> On 27/06/15 00:17, Liang Li wrote:
>> The function netif_set_real_num_tx_queues() will return -EINVAL if
>> the second parameter < 1, so call this function with the second
>> parameter set to 0 is meaningless.
>
> Reviewed-by: David Vrabel <david.vrabel@citrix.com>
Applied.
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2015-06-28 23:49 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2015-06-26 23:17 [PATCH] xen-netfront: Remove the meaningless code Liang Li
2015-06-26 15:15 ` David Vrabel
2015-06-28 23:49 ` David Miller
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).