[PATCH net] amd-xgbe: Add the __GFP_NOWARN flag to Rx buffer allocation

[PATCH net] amd-xgbe: Add the __GFP_NOWARN flag to Rx buffer allocation

[Tom Lendacky]

When allocating Rx related buffers, alloc_pages is called using an order
number that is decreased until successful. A system under stress can
experience failures during this allocation process resulting in a warning
being issued. This message can be of concern to end users even though the
failure is not fatal. Since the failure is not fatal and can occur
multiple times, the driver should include the __GFP_NOWARN flag to
suppress the warning message from being issued.

Signed-off-by: Tom Lendacky <thomas.lendacky@amd.com>
---
 drivers/net/ethernet/amd/xgbe/xgbe-desc.c |    2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/net/ethernet/amd/xgbe/xgbe-desc.c b/drivers/net/ethernet/amd/xgbe/xgbe-desc.c
index dd03ad8..661cdaa 100644
--- a/drivers/net/ethernet/amd/xgbe/xgbe-desc.c
+++ b/drivers/net/ethernet/amd/xgbe/xgbe-desc.c
@@ -268,7 +268,7 @@ static int xgbe_alloc_pages(struct xgbe_prv_data *pdata,
 	int ret;
 
 	/* Try to obtain pages, decreasing order if necessary */
-	gfp |= __GFP_COLD | __GFP_COMP;
+	gfp |= __GFP_COLD | __GFP_COMP | __GFP_NOWARN;
 	while (order >= 0) {
 		pages = alloc_pages(gfp, order);
 		if (pages)

Re: [PATCH net] amd-xgbe: Add the __GFP_NOWARN flag to Rx buffer allocation

[David Miller]

From: Tom Lendacky <thomas.lendacky@amd.com>
Date: Mon, 29 Jun 2015 11:22:12 -0500

> When allocating Rx related buffers, alloc_pages is called using an order
> number that is decreased until successful. A system under stress can
> experience failures during this allocation process resulting in a warning
> being issued. This message can be of concern to end users even though the
> failure is not fatal. Since the failure is not fatal and can occur
> multiple times, the driver should include the __GFP_NOWARN flag to
> suppress the warning message from being issued.
> 
> Signed-off-by: Tom Lendacky <thomas.lendacky@amd.com>

Applied, thanks.

Re: [PATCH net] amd-xgbe: Add the __GFP_NOWARN flag to Rx buffer allocation

[Tom Lendacky]

On 06/29/2015 11:27 AM, David Miller wrote:
> From: Tom Lendacky <thomas.lendacky@amd.com>
> Date: Mon, 29 Jun 2015 11:22:12 -0500
>
>> When allocating Rx related buffers, alloc_pages is called using an order
>> number that is decreased until successful. A system under stress can
>> experience failures during this allocation process resulting in a warning
>> being issued. This message can be of concern to end users even though the
>> failure is not fatal. Since the failure is not fatal and can occur
>> multiple times, the driver should include the __GFP_NOWARN flag to
>> suppress the warning message from being issued.
>>
>> Signed-off-by: Tom Lendacky <thomas.lendacky@amd.com>
>
> Applied, thanks.
>

Hi David,

Can this be queued up for stable 4.0/4.1 (it isn't applicable before
3.19)?

Thanks,
Tom

Re: [PATCH net] amd-xgbe: Add the __GFP_NOWARN flag to Rx buffer allocation

[David Miller]

From: Tom Lendacky <thomas.lendacky@amd.com>
Date: Mon, 29 Jun 2015 16:47:55 -0500

> On 06/29/2015 11:27 AM, David Miller wrote:
>> From: Tom Lendacky <thomas.lendacky@amd.com>
>> Date: Mon, 29 Jun 2015 11:22:12 -0500
>>
>>> When allocating Rx related buffers, alloc_pages is called using an
>>> order
>>> number that is decreased until successful. A system under stress can
>>> experience failures during this allocation process resulting in a
>>> warning
>>> being issued. This message can be of concern to end users even though
>>> the
>>> failure is not fatal. Since the failure is not fatal and can occur
>>> multiple times, the driver should include the __GFP_NOWARN flag to
>>> suppress the warning message from being issued.
>>>
>>> Signed-off-by: Tom Lendacky <thomas.lendacky@amd.com>
>>
>> Applied, thanks.
>>
> 
> Hi David,
> 
> Can this be queued up for stable 4.0/4.1 (it isn't applicable before
> 3.19)?

Done.