From: Nicolas Ferre <nicolas.ferre@atmel.com>
To: Nicolae Rosia <nicolae.rosia@certsign.ro>, <netdev@vger.kernel.org>
Cc: Cyrille Pitchen <cyrille.pitchen@atmel.com>
Subject: Re: [PATCH net-next] net: macb: replace literal constant with NET_IP_ALIGN
Date: Wed, 1 Jul 2015 12:03:23 +0200 [thread overview]
Message-ID: <5593BAEB.8030103@atmel.com> (raw)
In-Reply-To: <5592D105.7080006@certsign.ro>
Le 30/06/2015 19:25, Nicolae Rosia a écrit :
>
> Signed-off-by: Nicolae Rosia <nicolae.rosia@certsign.ro>
Acked-by: Nicolas Ferre <nicolas.ferre@atmel.com>
Thanks, bye.
> ---
> drivers/net/ethernet/cadence/macb.c | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/net/ethernet/cadence/macb.c b/drivers/net/ethernet/cadence/macb.c
> index caeb395..dbb5160 100644
> --- a/drivers/net/ethernet/cadence/macb.c
> +++ b/drivers/net/ethernet/cadence/macb.c
> @@ -2554,9 +2554,9 @@ static void at91ether_rx(struct net_device *dev)
> while (lp->rx_ring[lp->rx_tail].addr & MACB_BIT(RX_USED)) {
> p_recv = lp->rx_buffers + lp->rx_tail * AT91ETHER_MAX_RBUFF_SZ;
> pktlen = MACB_BF(RX_FRMLEN, lp->rx_ring[lp->rx_tail].ctrl);
> - skb = netdev_alloc_skb(dev, pktlen + 2);
> + skb = netdev_alloc_skb(dev, pktlen + NET_IP_ALIGN);
> if (skb) {
> - skb_reserve(skb, 2);
> + skb_reserve(skb, NET_IP_ALIGN);
> memcpy(skb_put(skb, pktlen), p_recv, pktlen);
>
> skb->protocol = eth_type_trans(skb, dev);
>
--
Nicolas Ferre
next prev parent reply other threads:[~2015-07-01 10:04 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-06-30 17:25 [PATCH net-next] net: macb: replace literal constant with NET_IP_ALIGN Nicolae Rosia
2015-07-01 10:03 ` Nicolas Ferre [this message]
2015-07-01 10:56 ` Eric Dumazet
2015-07-01 13:29 ` Nicolae Rosia
2015-07-01 13:44 ` Eric Dumazet
2015-07-01 14:29 ` Nicolae Rosia
2015-07-01 15:33 ` Eric Dumazet
2015-07-01 15:53 ` Nicolae Rosia
2015-07-01 16:19 ` Eric Dumazet
2015-07-01 17:06 ` Joe Perches
2015-07-01 22:13 ` Eric Dumazet
2015-07-01 23:00 ` Joe Perches
2015-07-03 16:18 ` David Laight
2015-07-03 16:39 ` Eric Dumazet
2015-07-06 8:54 ` David Laight
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5593BAEB.8030103@atmel.com \
--to=nicolas.ferre@atmel.com \
--cc=cyrille.pitchen@atmel.com \
--cc=netdev@vger.kernel.org \
--cc=nicolae.rosia@certsign.ro \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).