From: Nicolae Rosia <nicolae.rosia@certsign.ro>
To: Eric Dumazet <eric.dumazet@gmail.com>
Cc: Nicolas Ferre <nicolas.ferre@atmel.com>, <netdev@vger.kernel.org>
Subject: Re: [PATCH net-next] net: macb: replace literal constant with NET_IP_ALIGN
Date: Wed, 1 Jul 2015 17:29:42 +0300 [thread overview]
Message-ID: <5593F956.4020300@certsign.ro> (raw)
In-Reply-To: <1435758289.4110.130.camel@edumazet-glaptop2.roam.corp.google.com>
On 07/01/2015 04:44 PM, Eric Dumazet wrote:
> I really doubt this adapter can process millions of packets per second ?
I was suggesting this since I was taking into consideration the comment
from skbuff.c, "we can save several CPU cycles by avoiding having to
disable and re-enable IRQs."
Is there a downside to this?
>
> I would rather enable GRO, it would be more useful.
I had no idea what GRO is, so I have read about it [0] and looked at a
couple of drivers which use it. They all seem to
replace netif_receive_skb with napi_gro_receive and when there are no
more packets in napi_pool they call napi_gro_flush.
Is it that simple?
Regards
[0] https://lwn.net/Articles/358910/
next prev parent reply other threads:[~2015-07-01 14:30 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-06-30 17:25 [PATCH net-next] net: macb: replace literal constant with NET_IP_ALIGN Nicolae Rosia
2015-07-01 10:03 ` Nicolas Ferre
2015-07-01 10:56 ` Eric Dumazet
2015-07-01 13:29 ` Nicolae Rosia
2015-07-01 13:44 ` Eric Dumazet
2015-07-01 14:29 ` Nicolae Rosia [this message]
2015-07-01 15:33 ` Eric Dumazet
2015-07-01 15:53 ` Nicolae Rosia
2015-07-01 16:19 ` Eric Dumazet
2015-07-01 17:06 ` Joe Perches
2015-07-01 22:13 ` Eric Dumazet
2015-07-01 23:00 ` Joe Perches
2015-07-03 16:18 ` David Laight
2015-07-03 16:39 ` Eric Dumazet
2015-07-06 8:54 ` David Laight
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5593F956.4020300@certsign.ro \
--to=nicolae.rosia@certsign.ro \
--cc=eric.dumazet@gmail.com \
--cc=netdev@vger.kernel.org \
--cc=nicolas.ferre@atmel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).