From mboxrd@z Thu Jan 1 00:00:00 1970 From: Alexei Starovoitov Subject: Re: [PATCH net] net_sched: gen_estimator: extend pps limit Date: Thu, 02 Jul 2015 10:15:56 -0700 Message-ID: <559571CC.7070801@plumgrid.com> References: <1435845439.11970.25.camel@edumazet-glaptop2.roam.corp.google.com> Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: 7bit Cc: netdev , Jamal Hadi Salim , John Fastabend To: Eric Dumazet , David Miller Return-path: Received: from mail-pa0-f53.google.com ([209.85.220.53]:33872 "EHLO mail-pa0-f53.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753240AbbGBRP5 (ORCPT ); Thu, 2 Jul 2015 13:15:57 -0400 Received: by pabvl15 with SMTP id vl15so43496898pab.1 for ; Thu, 02 Jul 2015 10:15:56 -0700 (PDT) In-Reply-To: <1435845439.11970.25.camel@edumazet-glaptop2.roam.corp.google.com> Sender: netdev-owner@vger.kernel.org List-ID: On 7/2/15 6:57 AM, Eric Dumazet wrote: > From: Eric Dumazet > > rate estimators are limited to 4 Mpps, which was fine years ago, but > too small with current hardware generation. > > Lets use 2^5 scaling instead of 2^10 to get 128 Mpps new limit. > > On 64bit arch, use an "unsigned long" for temp storage and remove limit. > (We do not expect 32bit arches to be able to reach this point) > > Tested: > > tc -s -d filter sh dev eth0 parent ffff: > > filter protocol ip pref 1 u32 > filter protocol ip pref 1 u32 fh 800: ht divisor 1 > filter protocol ip pref 1 u32 fh 800::800 order 2048 key ht 800 bkt 0 flowid 1:15 > match 07000000/ff000000 at 12 > action order 1: gact action drop > random type none pass val 0 > index 1 ref 1 bind 1 installed 166 sec > Action statistics: > Sent 39734251496 bytes 863788076 pkt (dropped 863788117, overlimits 0 requeues 0) > rate 4067Mbit 11053596pps backlog 0b 0p requeues 0 > > Signed-off-by: Eric Dumazet Looks good to me. Acked-by: Alexei Starovoitov