netdev.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Daniel Borkmann <daniel@iogearbox.net>
To: Jason Gunthorpe <jgunthorpe@obsidianresearch.com>
Cc: netdev@vger.kernel.org,
	Mitch Williams <mitch.a.williams@intel.com>,
	Jeff Kirsher <jeffrey.t.kirsher@intel.com>,
	Nicolas Dichtel <nicolas.dichtel@6wind.com>,
	Jiri Pirko <jiri@resnulli.us>, Thomas Graf <tgraf@suug.ch>,
	"David S. Miller" <davem@davemloft.net>,
	Chris Wright <chrisw@sous-sol.org>
Subject: Re: [PATCH] rtnetlink: Actually use the policy for the IFLA_VF_INFO
Date: Fri, 03 Jul 2015 23:52:25 +0200	[thread overview]
Message-ID: <55970419.804@iogearbox.net> (raw)
In-Reply-To: <20150702230630.GA26691@obsidianresearch.com>

On 07/03/2015 01:06 AM, Jason Gunthorpe wrote:
> On Thu, Jul 02, 2015 at 10:34:54AM +0200, Daniel Borkmann wrote:
>>> So, commit c02db8c6290b moved it into a nested attribute (IFLA_VF_INFO)
>>> where we indeed don't do further validation. Imho, we should pass the
>>> parsed attribute table from nla_parse_nested() down into do_setvfinfo(),
>>> something like the below; I can give it a test run on my ixgbe.
>>
>> Sorry for the late reply, something like this looks good from my side.
>
> Okay, since it is your patch, will you send it to DaveM with my
> Reported-By?

Either way is fine by me, if you prefer, you can also just update your
initial submission. In any case, we should get it fixed eventually.

Thanks,
Daniel

  reply	other threads:[~2015-07-03 21:52 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-06-30 22:52 [PATCH] rtnetlink: Actually use the policy for the IFLA_VF_INFO Jason Gunthorpe
2015-07-01  9:36 ` Daniel Borkmann
2015-07-02  8:34   ` Daniel Borkmann
2015-07-02 23:06     ` Jason Gunthorpe
2015-07-03 21:52       ` Daniel Borkmann [this message]
2015-07-02 16:23   ` Jason Gunthorpe

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=55970419.804@iogearbox.net \
    --to=daniel@iogearbox.net \
    --cc=chrisw@sous-sol.org \
    --cc=davem@davemloft.net \
    --cc=jeffrey.t.kirsher@intel.com \
    --cc=jgunthorpe@obsidianresearch.com \
    --cc=jiri@resnulli.us \
    --cc=mitch.a.williams@intel.com \
    --cc=netdev@vger.kernel.org \
    --cc=nicolas.dichtel@6wind.com \
    --cc=tgraf@suug.ch \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).