From mboxrd@z Thu Jan 1 00:00:00 1970 From: Julien Grall Subject: Re: [Xen-devel] [PATCH] net/bridge: Add missing in6_dev_put in br_validate_ipv6 Date: Mon, 6 Jul 2015 12:32:43 +0100 Message-ID: <559A675B.80408@citrix.com> References: <1435946491-11148-1-git-send-email-julien.grall@citrix.com> <20150703204213.GM16529@breakpoint.cc> <559A5A0B.4040700@citrix.com> <20150706111952.GC16864@breakpoint.cc> Mime-Version: 1.0 Content-Type: text/plain; charset="windows-1252" Content-Transfer-Encoding: 7bit Cc: wei.liu2@citrix.com, ian.campbell@citrix.com, netdev@vger.kernel.org, bridge@lists.linux-foundation.org, linux-kernel@vger.kernel.org, Bernhard Thaler , xen-devel@lists.xenproject.org, davem@davemloft.net, Pablo Neira Ayuso To: Florian Westphal Return-path: In-Reply-To: <20150706111952.GC16864@breakpoint.cc> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: bridge-bounces@lists.linux-foundation.org Errors-To: bridge-bounces@lists.linux-foundation.org List-Id: netdev.vger.kernel.org On 06/07/15 12:19, Florian Westphal wrote: > Julien Grall wrote: >> On 03/07/15 21:42, Florian Westphal wrote: >>> I think it makes more sense to use __in6_dev_get() instead which doesn't >>> take a reference. >> >> __in6_dev_get requires to hold rcu_read_lock or RTNL. My knowledge on >> this code is very limited. Are we sure that one this lock is hold? At >> first glance, I wasn't able to find one. > > All netfilter hooks are rcu_read_locked via nf_hook_slow(). Ok. I will resend the patch with __in6_dev_get. > BTW, netfilter patches should be sent to netfilter-devel@vger.kernel.org. I used scripts/get_maintainer.pl which doesn't provide this mailing list for net/bridge/br_netfilter*.c Regards, -- Julien Grall