[patch iproute2] iproute2: ipa: show switch id

[patch iproute2] iproute2: ipa: show switch id

[Jiri Pirko]

We forgot to include this patch somehow. So do it now.

Signed-off-by: Jiri Pirko <jiri@resnulli.us>
---
 ip/ipaddress.c | 8 ++++++++
 1 file changed, 8 insertions(+)

diff --git a/ip/ipaddress.c b/ip/ipaddress.c
index 85a81ba..b7b4e3e 100644
--- a/ip/ipaddress.c
+++ b/ip/ipaddress.c
@@ -688,6 +688,14 @@ int print_linkinfo(const struct sockaddr_nl *who,
 				      b1, sizeof(b1)));
 	}
 
+	if (tb[IFLA_PHYS_SWITCH_ID]) {
+		SPRINT_BUF(b1);
+		fprintf(fp, "switchid %s ",
+			hexstring_n2a(RTA_DATA(tb[IFLA_PHYS_SWITCH_ID]),
+				      RTA_PAYLOAD(tb[IFLA_PHYS_SWITCH_ID]),
+				      b1, sizeof(b1)));
+	}
+
 	if (tb[IFLA_OPERSTATE])
 		print_operstate(fp, rta_getattr_u8(tb[IFLA_OPERSTATE]));
 
-- 
1.9.3

Re: [patch iproute2] iproute2: ipa: show switch id

[Andy Gospodarek]

On Wed, Jul 08, 2015 at 05:08:18PM +0200, Jiri Pirko wrote:
> We forgot to include this patch somehow. So do it now.
I noticed this the other day and wondered where it was.  Thanks for
posting it before I searched archives wondering why it was not.

> 
> Signed-off-by: Jiri Pirko <jiri@resnulli.us>
Acked-by: Andy Gospodarek <gospo@cumulusnetworks.com>

Re: [patch iproute2] iproute2: ipa: show switch id

[David Ahern]

On 7/8/15 9:08 AM, Jiri Pirko wrote:
> We forgot to include this patch somehow. So do it now.
>
> Signed-off-by: Jiri Pirko <jiri@resnulli.us>
> ---
>   ip/ipaddress.c | 8 ++++++++
>   1 file changed, 8 insertions(+)
>
> diff --git a/ip/ipaddress.c b/ip/ipaddress.c
> index 85a81ba..b7b4e3e 100644
> --- a/ip/ipaddress.c
> +++ b/ip/ipaddress.c
> @@ -688,6 +688,14 @@ int print_linkinfo(const struct sockaddr_nl *who,
>   				      b1, sizeof(b1)));
>   	}
>
> +	if (tb[IFLA_PHYS_SWITCH_ID]) {
> +		SPRINT_BUF(b1);
> +		fprintf(fp, "switchid %s ",
> +			hexstring_n2a(RTA_DATA(tb[IFLA_PHYS_SWITCH_ID]),
> +				      RTA_PAYLOAD(tb[IFLA_PHYS_SWITCH_ID]),
> +				      b1, sizeof(b1)));
> +	}
> +
>   	if (tb[IFLA_OPERSTATE])
>   		print_operstate(fp, rta_getattr_u8(tb[IFLA_OPERSTATE]));
>
>

Do Stephen's comments about port-name apply here?
    http://www.spinics.net/lists/netdev/msg322693.html

I was wondering if this should go into -details output rather than the 
default.

Re: [patch iproute2] iproute2: ipa: show switch id

[Stephen Hemminger]

On Wed,  8 Jul 2015 17:08:18 +0200
Jiri Pirko <jiri@resnulli.us> wrote:

>  
> +	if (tb[IFLA_PHYS_SWITCH_ID]) {
> +		SPRINT_BUF(b1);
> +		fprintf(fp, "switchid %s ",
> +			hexstring_n2a(RTA_DATA(tb[IFLA_PHYS_SWITCH_ID]),
> +				      RTA_PAYLOAD(tb[IFLA_PHYS_SWITCH_ID]),
> +				      b1, sizeof(b1)));
> +	}
> +

Ok, but why hex?

Re: [patch iproute2] iproute2: ipa: show switch id

[Jiri Pirko]

Thu, Jul 09, 2015 at 03:05:10AM CEST, stephen@networkplumber.org wrote:
>On Wed,  8 Jul 2015 17:08:18 +0200
>Jiri Pirko <jiri@resnulli.us> wrote:
>
>>  
>> +	if (tb[IFLA_PHYS_SWITCH_ID]) {
>> +		SPRINT_BUF(b1);
>> +		fprintf(fp, "switchid %s ",
>> +			hexstring_n2a(RTA_DATA(tb[IFLA_PHYS_SWITCH_ID]),
>> +				      RTA_PAYLOAD(tb[IFLA_PHYS_SWITCH_ID]),
>> +				      b1, sizeof(b1)));
>> +	}
>> +
>
>Ok, but why hex?

What else? It is an arbitrary byte array.

Re: [patch iproute2] iproute2: ipa: show switch id

[Jiri Pirko]

Wed, Jul 08, 2015 at 11:29:42PM CEST, dsahern@gmail.com wrote:
>On 7/8/15 9:08 AM, Jiri Pirko wrote:
>>We forgot to include this patch somehow. So do it now.
>>
>>Signed-off-by: Jiri Pirko <jiri@resnulli.us>
>>---
>>  ip/ipaddress.c | 8 ++++++++
>>  1 file changed, 8 insertions(+)
>>
>>diff --git a/ip/ipaddress.c b/ip/ipaddress.c
>>index 85a81ba..b7b4e3e 100644
>>--- a/ip/ipaddress.c
>>+++ b/ip/ipaddress.c
>>@@ -688,6 +688,14 @@ int print_linkinfo(const struct sockaddr_nl *who,
>>  				      b1, sizeof(b1)));
>>  	}
>>
>>+	if (tb[IFLA_PHYS_SWITCH_ID]) {
>>+		SPRINT_BUF(b1);
>>+		fprintf(fp, "switchid %s ",
>>+			hexstring_n2a(RTA_DATA(tb[IFLA_PHYS_SWITCH_ID]),
>>+				      RTA_PAYLOAD(tb[IFLA_PHYS_SWITCH_ID]),
>>+				      b1, sizeof(b1)));
>>+	}
>>+
>>  	if (tb[IFLA_OPERSTATE])
>>  		print_operstate(fp, rta_getattr_u8(tb[IFLA_OPERSTATE]));
>>
>>
>
>Do Stephen's comments about port-name apply here?
>   http://www.spinics.net/lists/netdev/msg322693.html
>
>I was wondering if this should go into -details output rather than the
>default.

I would like to have this in default. It is very important info for user
who has switch device. He should see this right away.

Re: [patch iproute2] iproute2: ipa: show switch id

[Stephen Hemminger]

On Thu, 9 Jul 2015 08:09:18 +0200
Jiri Pirko <jiri@resnulli.us> wrote:

> Thu, Jul 09, 2015 at 03:05:10AM CEST, stephen@networkplumber.org wrote:
> >On Wed,  8 Jul 2015 17:08:18 +0200
> >Jiri Pirko <jiri@resnulli.us> wrote:
> >
> >>  
> >> +	if (tb[IFLA_PHYS_SWITCH_ID]) {
> >> +		SPRINT_BUF(b1);
> >> +		fprintf(fp, "switchid %s ",
> >> +			hexstring_n2a(RTA_DATA(tb[IFLA_PHYS_SWITCH_ID]),
> >> +				      RTA_PAYLOAD(tb[IFLA_PHYS_SWITCH_ID]),
> >> +				      b1, sizeof(b1)));
> >> +	}
> >> +
> >
> >Ok, but why hex?
> 
> What else? It is an arbitrary byte array.

Ok I though it was a number.