* [PATCH] net: systemport: Use eth_hw_addr_random
@ 2015-07-08 5:19 Vaishali Thakkar
2015-07-09 5:01 ` Florian Fainelli
` (2 more replies)
0 siblings, 3 replies; 4+ messages in thread
From: Vaishali Thakkar @ 2015-07-08 5:19 UTC (permalink / raw)
To: Florian Fainelli, netdev, linux-kernel
Use eth_hw_addr_random() instead of calling random_ether_addr().
Here, this change is setting addr_assign_type to NET_ADDR_RANDOM.
The Coccinelle semantic patch that performs this transformation
is as follows:
@@
identifier a,b;
@@
-random_ether_addr(a->b);
+eth_hw_addr_random(a);
Signed-off-by: Vaishali Thakkar <vthakkar1994@gmail.com>
---
Note that this patch is compile tested only and I have used file
drivers/net/ethernet/hisilicon/hix5hd2_gmac.c as a reference.
Also, original call didn't make assignment to NET_ADDR_RANDOM. So,
it would be good if someone can test this change.
---
drivers/net/ethernet/broadcom/bcmsysport.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/net/ethernet/broadcom/bcmsysport.c b/drivers/net/ethernet/broadcom/bcmsysport.c
index 909ad7a..4566cdf 100644
--- a/drivers/net/ethernet/broadcom/bcmsysport.c
+++ b/drivers/net/ethernet/broadcom/bcmsysport.c
@@ -1793,7 +1793,7 @@ static int bcm_sysport_probe(struct platform_device *pdev)
macaddr = of_get_mac_address(dn);
if (!macaddr || !is_valid_ether_addr(macaddr)) {
dev_warn(&pdev->dev, "using random Ethernet MAC\n");
- random_ether_addr(dev->dev_addr);
+ eth_hw_addr_random(dev);
} else {
ether_addr_copy(dev->dev_addr, macaddr);
}
--
1.9.1
^ permalink raw reply related [flat|nested] 4+ messages in thread* Re: [PATCH] net: systemport: Use eth_hw_addr_random
2015-07-08 5:19 [PATCH] net: systemport: Use eth_hw_addr_random Vaishali Thakkar
@ 2015-07-09 5:01 ` Florian Fainelli
2015-07-09 21:31 ` Florian Fainelli
2015-07-09 21:51 ` David Miller
2 siblings, 0 replies; 4+ messages in thread
From: Florian Fainelli @ 2015-07-09 5:01 UTC (permalink / raw)
To: Vaishali Thakkar, netdev, linux-kernel
Le 07/07/15 22:19, Vaishali Thakkar a écrit :
> Use eth_hw_addr_random() instead of calling random_ether_addr().
> Here, this change is setting addr_assign_type to NET_ADDR_RANDOM.
>
> The Coccinelle semantic patch that performs this transformation
> is as follows:
>
> @@
> identifier a,b;
> @@
>
> -random_ether_addr(a->b);
> +eth_hw_addr_random(a);
>
> Signed-off-by: Vaishali Thakkar <vthakkar1994@gmail.com>
> ---
> Note that this patch is compile tested only and I have used file
> drivers/net/ethernet/hisilicon/hix5hd2_gmac.c as a reference.
> Also, original call didn't make assignment to NET_ADDR_RANDOM. So,
> it would be good if someone can test this change.
Thanks, I will give this a try and report.
> ---
> drivers/net/ethernet/broadcom/bcmsysport.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/net/ethernet/broadcom/bcmsysport.c b/drivers/net/ethernet/broadcom/bcmsysport.c
> index 909ad7a..4566cdf 100644
> --- a/drivers/net/ethernet/broadcom/bcmsysport.c
> +++ b/drivers/net/ethernet/broadcom/bcmsysport.c
> @@ -1793,7 +1793,7 @@ static int bcm_sysport_probe(struct platform_device *pdev)
> macaddr = of_get_mac_address(dn);
> if (!macaddr || !is_valid_ether_addr(macaddr)) {
> dev_warn(&pdev->dev, "using random Ethernet MAC\n");
> - random_ether_addr(dev->dev_addr);
> + eth_hw_addr_random(dev);
> } else {
> ether_addr_copy(dev->dev_addr, macaddr);
> }
>
--
Florian
^ permalink raw reply [flat|nested] 4+ messages in thread* Re: [PATCH] net: systemport: Use eth_hw_addr_random
2015-07-08 5:19 [PATCH] net: systemport: Use eth_hw_addr_random Vaishali Thakkar
2015-07-09 5:01 ` Florian Fainelli
@ 2015-07-09 21:31 ` Florian Fainelli
2015-07-09 21:51 ` David Miller
2 siblings, 0 replies; 4+ messages in thread
From: Florian Fainelli @ 2015-07-09 21:31 UTC (permalink / raw)
To: Vaishali Thakkar, netdev, linux-kernel
On 07/07/15 22:19, Vaishali Thakkar wrote:
> Use eth_hw_addr_random() instead of calling random_ether_addr().
> Here, this change is setting addr_assign_type to NET_ADDR_RANDOM.
>
> The Coccinelle semantic patch that performs this transformation
> is as follows:
>
> @@
> identifier a,b;
> @@
>
> -random_ether_addr(a->b);
> +eth_hw_addr_random(a);
>
> Signed-off-by: Vaishali Thakkar <vthakkar1994@gmail.com>
Tested-by: Florian Fainelli <f.fainelli@gmail.com>
Reviewed-by: Florian Fainelli <f.fainelli@gmail.com>
> ---
> Note that this patch is compile tested only and I have used file
> drivers/net/ethernet/hisilicon/hix5hd2_gmac.c as a reference.
> Also, original call didn't make assignment to NET_ADDR_RANDOM. So,
> it would be good if someone can test this change.
> ---
> drivers/net/ethernet/broadcom/bcmsysport.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/net/ethernet/broadcom/bcmsysport.c b/drivers/net/ethernet/broadcom/bcmsysport.c
> index 909ad7a..4566cdf 100644
> --- a/drivers/net/ethernet/broadcom/bcmsysport.c
> +++ b/drivers/net/ethernet/broadcom/bcmsysport.c
> @@ -1793,7 +1793,7 @@ static int bcm_sysport_probe(struct platform_device *pdev)
> macaddr = of_get_mac_address(dn);
> if (!macaddr || !is_valid_ether_addr(macaddr)) {
> dev_warn(&pdev->dev, "using random Ethernet MAC\n");
> - random_ether_addr(dev->dev_addr);
> + eth_hw_addr_random(dev);
> } else {
> ether_addr_copy(dev->dev_addr, macaddr);
> }
>
--
Florian
^ permalink raw reply [flat|nested] 4+ messages in thread* Re: [PATCH] net: systemport: Use eth_hw_addr_random
2015-07-08 5:19 [PATCH] net: systemport: Use eth_hw_addr_random Vaishali Thakkar
2015-07-09 5:01 ` Florian Fainelli
2015-07-09 21:31 ` Florian Fainelli
@ 2015-07-09 21:51 ` David Miller
2 siblings, 0 replies; 4+ messages in thread
From: David Miller @ 2015-07-09 21:51 UTC (permalink / raw)
To: vthakkar1994; +Cc: f.fainelli, netdev, linux-kernel
From: Vaishali Thakkar <vthakkar1994@gmail.com>
Date: Wed, 8 Jul 2015 10:49:30 +0530
> Use eth_hw_addr_random() instead of calling random_ether_addr().
> Here, this change is setting addr_assign_type to NET_ADDR_RANDOM.
>
> The Coccinelle semantic patch that performs this transformation
> is as follows:
>
> @@
> identifier a,b;
> @@
>
> -random_ether_addr(a->b);
> +eth_hw_addr_random(a);
>
> Signed-off-by: Vaishali Thakkar <vthakkar1994@gmail.com>
Applied, thanks.
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2015-07-09 21:51 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2015-07-08 5:19 [PATCH] net: systemport: Use eth_hw_addr_random Vaishali Thakkar
2015-07-09 5:01 ` Florian Fainelli
2015-07-09 21:31 ` Florian Fainelli
2015-07-09 21:51 ` David Miller
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).