From: Florian Fainelli <f.fainelli@gmail.com>
To: Petri Gynther <pgynther@google.com>, netdev@vger.kernel.org
Cc: davem@davemloft.net
Subject: Re: [PATCH net] net: bcmgenet: fix accounting of packet drops vs errors
Date: Wed, 08 Jul 2015 22:02:39 -0700 [thread overview]
Message-ID: <559E006F.4010900@gmail.com> (raw)
In-Reply-To: <089e0122a88432eb63051a678bba@google.com>
Le 07/08/15 18:55, Petri Gynther a écrit :
> bcmgenet driver needs to separate packet drops from packet errors.
>
> When the driver has to drop a *good* packet, due to lack of buffers or
> replacement skbs, increment only dev->stats.[rx|tx]_dropped.
>
> When the driver encounters a bad Rx packet or Tx error, increment only
> dev->stats.[rx|tx]_errors + relevant detailed error counter.
>
> Signed-off-by: Petri Gynther <pgynther@google.com>
Reviewed-by: Florian Fainelli <f.fainelli@gmail.com>
> ---
> drivers/net/ethernet/broadcom/genet/bcmgenet.c | 4 ----
> 1 file changed, 4 deletions(-)
>
> diff --git a/drivers/net/ethernet/broadcom/genet/bcmgenet.c
> b/drivers/net/ethernet/broadcom/genet/bcmgenet.c
> index b43b2cb..64c1e9d 100644
> --- a/drivers/net/ethernet/broadcom/genet/bcmgenet.c
> +++ b/drivers/net/ethernet/broadcom/genet/bcmgenet.c
> @@ -1230,7 +1230,6 @@ static struct sk_buff *bcmgenet_put_tx_csum(struct
> net_device *dev,
> new_skb = skb_realloc_headroom(skb, sizeof(*status));
> dev_kfree_skb(skb);
> if (!new_skb) {
> - dev->stats.tx_errors++;
> dev->stats.tx_dropped++;
> return NULL;
> }
> @@ -1465,7 +1464,6 @@ static unsigned int bcmgenet_desc_rx(struct
> bcmgenet_rx_ring *ring,
>
> if (unlikely(!skb)) {
> dev->stats.rx_dropped++;
> - dev->stats.rx_errors++;
> goto next;
> }
>
> @@ -1493,7 +1491,6 @@ static unsigned int bcmgenet_desc_rx(struct
> bcmgenet_rx_ring *ring,
> if (unlikely(!(dma_flag & DMA_EOP) || !(dma_flag & DMA_SOP))) {
> netif_err(priv, rx_status, dev,
> "dropping fragmented packet!\n");
> - dev->stats.rx_dropped++;
> dev->stats.rx_errors++;
> dev_kfree_skb_any(skb);
> goto next;
> @@ -1515,7 +1512,6 @@ static unsigned int bcmgenet_desc_rx(struct
> bcmgenet_rx_ring *ring,
> dev->stats.rx_frame_errors++;
> if (dma_flag & DMA_RX_LG)
> dev->stats.rx_length_errors++;
> - dev->stats.rx_dropped++;
> dev->stats.rx_errors++;
> dev_kfree_skb_any(skb);
> goto next;
--
Florian
next prev parent reply other threads:[~2015-07-09 5:02 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-07-09 1:55 [PATCH net] net: bcmgenet: fix accounting of packet drops vs errors Petri Gynther
2015-07-09 5:02 ` Florian Fainelli [this message]
2015-07-10 4:10 ` David Miller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=559E006F.4010900@gmail.com \
--to=f.fainelli@gmail.com \
--cc=davem@davemloft.net \
--cc=netdev@vger.kernel.org \
--cc=pgynther@google.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).