From: Sergei Shtylyov <sergei.shtylyov@cogentembedded.com>
To: sfeldma@gmail.com, netdev@vger.kernel.org
Cc: jiri@resnulli.us, roopa@cumulusnetworks.com
Subject: Re: [PATCH net-next 2/5] net: add phys ID compare helper to test if two IDs are the same
Date: Thu, 9 Jul 2015 15:15:35 +0300 [thread overview]
Message-ID: <559E65E7.3040607@cogentembedded.com> (raw)
In-Reply-To: <1436397403-62412-3-git-send-email-sfeldma@gmail.com>
Hello.
On 7/9/2015 2:16 AM, sfeldma@gmail.com wrote:
> From: Scott Feldman <sfeldma@gmail.com>
> Signed-off-by: Scott Feldman <sfeldma@gmail.com>
> ---
> include/linux/netdevice.h | 7 +++++++
> net/switchdev/switchdev.c | 8 ++------
> 2 files changed, 9 insertions(+), 6 deletions(-)
[...]
> diff --git a/net/switchdev/switchdev.c b/net/switchdev/switchdev.c
> index 84f77a0..e16586f 100644
> --- a/net/switchdev/switchdev.c
> +++ b/net/switchdev/switchdev.c
> @@ -906,13 +906,9 @@ static struct net_device *switchdev_get_dev_by_nhs(struct fib_info *fi)
> if (switchdev_port_attr_get(dev, &attr))
> return NULL;
>
> - if (nhsel > 0) {
> - if (prev_attr.u.ppid.id_len != attr.u.ppid.id_len)
> + if (nhsel > 0 &&
> + !netdev_phys_item_id_same(&prev_attr.u.ppid, &attr.u.ppid))
> return NULL;
This line should be re-indented now, it starts too far to the right.
[...]
WBR, Sergei
next prev parent reply other threads:[~2015-07-09 12:15 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-07-08 23:16 [PATCH net-next 0/5] switchdev: avoid duplicate packet forwarding sfeldma
2015-07-08 23:16 ` [PATCH net-next 1/5] net: don't reforward packets already forwarded by offload device sfeldma
2015-07-09 22:22 ` David Miller
2015-07-08 23:16 ` [PATCH net-next 2/5] net: add phys ID compare helper to test if two IDs are the same sfeldma
2015-07-09 12:15 ` Sergei Shtylyov [this message]
2015-07-08 23:16 ` [PATCH net-next 3/5] switchdev: add offload_fwd_mark generator helper sfeldma
2015-07-08 23:16 ` [PATCH net-next 4/5] rocker: add offload_fwd_mark support sfeldma
2015-07-09 4:26 ` Simon Horman
2015-07-09 5:35 ` Scott Feldman
2015-07-08 23:16 ` [PATCH net-next 5/5] switchdev: update documentation for offload_fwd_mark sfeldma
2015-07-09 4:27 ` Simon Horman
2015-07-09 5:57 ` Scott Feldman
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=559E65E7.3040607@cogentembedded.com \
--to=sergei.shtylyov@cogentembedded.com \
--cc=jiri@resnulli.us \
--cc=netdev@vger.kernel.org \
--cc=roopa@cumulusnetworks.com \
--cc=sfeldma@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).