From: Chris Metcalf <cmetcalf@ezchip.com>
To: Josh Cartwright <joshc@ni.com>
Cc: Frederic Weisbecker <fweisbec@gmail.com>,
<netdev@vger.kernel.org>, <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH v2] nohz: prevent tilegx network driver interrupts
Date: Fri, 10 Jul 2015 19:06:23 -0400 [thread overview]
Message-ID: <55A04FEF.2000204@ezchip.com> (raw)
In-Reply-To: <20150710224500.GA25028@jcartwri.amer.corp.natinst.com>
On 7/10/2015 6:45 PM, Josh Cartwright wrote:
>> +static inline const struct cpumask *housekeeping_cpumask(void)
>> >+{
>> >+#ifdef CONFIG_NO_HZ_FULL
>> >+ if (tick_nohz_full_enabled())
>> >+ return housekeeping_mask;
>> >+#endif
> Just a small comment:
>
> We can take these checks out from under a #ifdef CONFIG_NO_HZ_FULL
> check, given that are stubbed tick_nohz_full_enabled() defined above.
True for the "if" clause, but the "housekeeping_mask" variable is only defined
under CONFIG_NO_HZ_FULL.
--
Chris Metcalf, EZChip Semiconductor
http://www.ezchip.com
next prev parent reply other threads:[~2015-07-10 23:06 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-07-10 17:33 [PATCH] nohz: prevent tilegx network driver interrupts Chris Metcalf
2015-07-10 18:24 ` Frederic Weisbecker
2015-07-10 19:05 ` Chris Metcalf
2015-07-10 19:37 ` [PATCH v2] " Chris Metcalf
2015-07-10 22:45 ` Josh Cartwright
2015-07-10 23:06 ` Chris Metcalf [this message]
2015-07-10 23:12 ` Josh Cartwright
2015-07-11 14:44 ` Frederic Weisbecker
2015-07-11 15:04 ` Chris Metcalf
2015-07-11 14:30 ` [PATCH] " Frederic Weisbecker
2015-07-20 21:22 ` Chris Metcalf
2015-07-20 21:49 ` Frederic Weisbecker
2015-07-20 22:15 ` Chris Metcalf
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=55A04FEF.2000204@ezchip.com \
--to=cmetcalf@ezchip.com \
--cc=fweisbec@gmail.com \
--cc=joshc@ni.com \
--cc=linux-kernel@vger.kernel.org \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).