* [PATCH net-next v6 3/4] rocker: Handle protodown notifications.
@ 2015-07-14 15:32 anuradhak
2015-07-14 16:42 ` Sergei Shtylyov
0 siblings, 1 reply; 3+ messages in thread
From: anuradhak @ 2015-07-14 15:32 UTC (permalink / raw)
To: davem, sfeldma; +Cc: netdev, roopa, gospo, wkok, anuradhak
From: Anuradha Karuppiah <anuradhak@cumulusnetworks.com>
protodown can be set by user space applications like MLAG on detecting
errors on a switch port. This patch provides sample switch driver changes
for handling protodown. Rocker PHYS disables the port in response to
protodown.
Signed-off-by: Anuradha Karuppiah <anuradhak@cumulusnetworks.com>
Signed-off-by: Andy Gospodarek <gospo@cumulusnetworks.com>
Signed-off-by: Roopa Prabhu <roopa@cumulusnetworks.com>
Signed-off-by: Wilson Kok <wkok@cumulusnetworks.com>
---
drivers/net/ethernet/rocker/rocker.c | 19 ++++++++++++++++++-
1 file changed, 18 insertions(+), 1 deletion(-)
diff --git a/drivers/net/ethernet/rocker/rocker.c b/drivers/net/ethernet/rocker/rocker.c
index 2d8578cade..ec950d9 100644
--- a/drivers/net/ethernet/rocker/rocker.c
+++ b/drivers/net/ethernet/rocker/rocker.c
@@ -3983,7 +3983,8 @@ static int rocker_port_open(struct net_device *dev)
napi_enable(&rocker_port->napi_tx);
napi_enable(&rocker_port->napi_rx);
- rocker_port_set_enable(rocker_port, true);
+ if (!(dev->proto_down))
+ rocker_port_set_enable(rocker_port, true);
netif_start_queue(dev);
return 0;
@@ -4167,6 +4168,21 @@ static int rocker_port_get_phys_port_name(struct net_device *dev,
return err ? -EOPNOTSUPP : 0;
}
+static int rocker_port_change_proto_down(struct net_device *dev,
+ bool proto_down)
+{
+ struct rocker_port *rocker_port = netdev_priv(dev);
+
+ if (rocker_port->dev->flags & IFF_UP) {
+ if (proto_down)
+ rocker_port_set_enable(rocker_port, false);
+ else
+ rocker_port_set_enable(rocker_port, true);
+ }
+ rocker_port->dev->proto_down = proto_down;
+ return 0;
+}
+
static const struct net_device_ops rocker_port_netdev_ops = {
.ndo_open = rocker_port_open,
.ndo_stop = rocker_port_stop,
@@ -4179,6 +4195,7 @@ static const struct net_device_ops rocker_port_netdev_ops = {
.ndo_fdb_del = switchdev_port_fdb_del,
.ndo_fdb_dump = switchdev_port_fdb_dump,
.ndo_get_phys_port_name = rocker_port_get_phys_port_name,
+ .ndo_change_proto_down = rocker_port_change_proto_down,
};
/********************
--
1.7.10.4
^ permalink raw reply related [flat|nested] 3+ messages in thread* Re: [PATCH net-next v6 3/4] rocker: Handle protodown notifications.
2015-07-14 15:32 [PATCH net-next v6 3/4] rocker: Handle protodown notifications anuradhak
@ 2015-07-14 16:42 ` Sergei Shtylyov
2015-07-14 20:30 ` Anuradha Karuppiah
0 siblings, 1 reply; 3+ messages in thread
From: Sergei Shtylyov @ 2015-07-14 16:42 UTC (permalink / raw)
To: anuradhak, davem, sfeldma; +Cc: netdev, roopa, gospo, wkok
Hello.
On 07/14/2015 06:32 PM, anuradhak@cumulusnetworks.com wrote:
> From: Anuradha Karuppiah <anuradhak@cumulusnetworks.com>
> protodown can be set by user space applications like MLAG on detecting
> errors on a switch port. This patch provides sample switch driver changes
> for handling protodown. Rocker PHYS disables the port in response to
> protodown.
> Signed-off-by: Anuradha Karuppiah <anuradhak@cumulusnetworks.com>
> Signed-off-by: Andy Gospodarek <gospo@cumulusnetworks.com>
> Signed-off-by: Roopa Prabhu <roopa@cumulusnetworks.com>
> Signed-off-by: Wilson Kok <wkok@cumulusnetworks.com>
> ---
> drivers/net/ethernet/rocker/rocker.c | 19 ++++++++++++++++++-
> 1 file changed, 18 insertions(+), 1 deletion(-)
> diff --git a/drivers/net/ethernet/rocker/rocker.c b/drivers/net/ethernet/rocker/rocker.c
> index 2d8578cade..ec950d9 100644
> --- a/drivers/net/ethernet/rocker/rocker.c
> +++ b/drivers/net/ethernet/rocker/rocker.c
> @@ -3983,7 +3983,8 @@ static int rocker_port_open(struct net_device *dev)
>
> napi_enable(&rocker_port->napi_tx);
> napi_enable(&rocker_port->napi_rx);
> - rocker_port_set_enable(rocker_port, true);
> + if (!(dev->proto_down))
Inner parens not needed.
> + rocker_port_set_enable(rocker_port, true);
> netif_start_queue(dev);
> return 0;
>
> @@ -4167,6 +4168,21 @@ static int rocker_port_get_phys_port_name(struct net_device *dev,
> return err ? -EOPNOTSUPP : 0;
> }
>
> +static int rocker_port_change_proto_down(struct net_device *dev,
> + bool proto_down)
> +{
> + struct rocker_port *rocker_port = netdev_priv(dev);
> +
> + if (rocker_port->dev->flags & IFF_UP) {
> + if (proto_down)
> + rocker_port_set_enable(rocker_port, false);
> + else
> + rocker_port_set_enable(rocker_port, true);
Why not:
rocker_port_set_enable(rocker_port, !proto_down);
[...]
MBR, Sergei
^ permalink raw reply [flat|nested] 3+ messages in thread* Re: [PATCH net-next v6 3/4] rocker: Handle protodown notifications.
2015-07-14 16:42 ` Sergei Shtylyov
@ 2015-07-14 20:30 ` Anuradha Karuppiah
0 siblings, 0 replies; 3+ messages in thread
From: Anuradha Karuppiah @ 2015-07-14 20:30 UTC (permalink / raw)
To: Sergei Shtylyov
Cc: David S. Miller, Scott Feldman, netdev@vger.kernel.org,
Roopa Prabhu, Andy Gospodarek, Wilson Kok
On Tue, Jul 14, 2015 at 9:42 AM, Sergei Shtylyov
<sergei.shtylyov@cogentembedded.com> wrote:
> Hello.
>
> On 07/14/2015 06:32 PM, anuradhak@cumulusnetworks.com wrote:
>
>> From: Anuradha Karuppiah <anuradhak@cumulusnetworks.com>
>
>
>> protodown can be set by user space applications like MLAG on detecting
>> errors on a switch port. This patch provides sample switch driver changes
>> for handling protodown. Rocker PHYS disables the port in response to
>> protodown.
>
>
>> Signed-off-by: Anuradha Karuppiah <anuradhak@cumulusnetworks.com>
>> Signed-off-by: Andy Gospodarek <gospo@cumulusnetworks.com>
>> Signed-off-by: Roopa Prabhu <roopa@cumulusnetworks.com>
>> Signed-off-by: Wilson Kok <wkok@cumulusnetworks.com>
>> ---
>> drivers/net/ethernet/rocker/rocker.c | 19 ++++++++++++++++++-
>> 1 file changed, 18 insertions(+), 1 deletion(-)
>
>
>> diff --git a/drivers/net/ethernet/rocker/rocker.c
>> b/drivers/net/ethernet/rocker/rocker.c
>> index 2d8578cade..ec950d9 100644
>> --- a/drivers/net/ethernet/rocker/rocker.c
>> +++ b/drivers/net/ethernet/rocker/rocker.c
>> @@ -3983,7 +3983,8 @@ static int rocker_port_open(struct net_device *dev)
>>
>> napi_enable(&rocker_port->napi_tx);
>> napi_enable(&rocker_port->napi_rx);
>> - rocker_port_set_enable(rocker_port, true);
>> + if (!(dev->proto_down))
>
>
> Inner parens not needed.
Ack.
>
>> + rocker_port_set_enable(rocker_port, true);
>> netif_start_queue(dev);
>> return 0;
>>
>> @@ -4167,6 +4168,21 @@ static int rocker_port_get_phys_port_name(struct
>> net_device *dev,
>> return err ? -EOPNOTSUPP : 0;
>> }
>>
>> +static int rocker_port_change_proto_down(struct net_device *dev,
>> + bool proto_down)
>> +{
>> + struct rocker_port *rocker_port = netdev_priv(dev);
>> +
>> + if (rocker_port->dev->flags & IFF_UP) {
>> + if (proto_down)
>> + rocker_port_set_enable(rocker_port, false);
>> + else
>> + rocker_port_set_enable(rocker_port, true);
>
>
> Why not:
>
> rocker_port_set_enable(rocker_port, !proto_down);
yes, that would be better. thanks for the review.
>
> [...]
>
> MBR, Sergei
>
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2015-07-14 20:30 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2015-07-14 15:32 [PATCH net-next v6 3/4] rocker: Handle protodown notifications anuradhak
2015-07-14 16:42 ` Sergei Shtylyov
2015-07-14 20:30 ` Anuradha Karuppiah
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).