From: Sergei Shtylyov <sergei.shtylyov@cogentembedded.com>
To: netdev@vger.kernel.org, David Miller <davem@davemloft.net>
Cc: linux-sh@vger.kernel.org
Subject: Re: [PATCH] ravb: do not invalidate cache for RX buffer twice
Date: Wed, 15 Jul 2015 15:11:07 +0300 [thread overview]
Message-ID: <55A64DDB.4010108@cogentembedded.com> (raw)
In-Reply-To: <55A639CE.2030201@cogentembedded.com>
On 7/15/2015 1:45 PM, Sergei Shtylyov wrote:
>> First, dma_sync_single_for_cpu() shouldn't have been called in the first place
>> (it's a streaming DMA API). dma_unmap_single() should have been called instead.
> ^
> Oops, I meant comma here.
>> Second, dma_unmap_single() call after handing the buffer to napi_gro_receive()
>> makes little sense.
> Moreover, 'desc->dptr' may not be valid at this point...
>> Signed-off-by: Sergei Shtylyov <sergei.shtylyov@cogentembedded.com>
>> ---
>> The patch is against Dave Miller's 'net.git' repo.
>> Don't know why I missed this DMA API misuse while working on the driver. :-<
> Dave, do you want me to resend the patch with fixed up changelog?
Oops, forgot to CC Dave. :-(
WBR, Sergei
next prev parent reply other threads:[~2015-07-15 12:11 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-07-14 21:56 [PATCH] ravb: do not invalidate cache for RX buffer twice Sergei Shtylyov
2015-07-15 10:45 ` Sergei Shtylyov
2015-07-15 12:11 ` Sergei Shtylyov [this message]
2015-07-17 7:11 ` David Miller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=55A64DDB.4010108@cogentembedded.com \
--to=sergei.shtylyov@cogentembedded.com \
--cc=davem@davemloft.net \
--cc=linux-sh@vger.kernel.org \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).