[PATCH net-next]r8169: set bits on Register Interrupt status on limit

[PATCH net-next]r8169: set bits on Register Interrupt status on limit

[Corcodel Marian]

[-- Attachment #1: Type: text/plain, Size: 459 bytes --]


 Set bits on register Interrupt status on limits by
configuration(critical).
 On chips not alls bits is in use and some is reserved this patch solve this issue.

 Committer: Corcodel Marian <asu@192-168-0-3.rdsnet.ro>
 Changes to be committed:
	modified:   drivers/net/ethernet/realtek/r8169.c

Signed-off-by: Corcodel Marian <corcodel.marian@gmail.com>
---
 drivers/net/ethernet/realtek/r8169.c | 7 +++++--
 1 file changed, 5 insertions(+), 2 deletions(-)


[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: 0001-Signed-off-by-Corcodel-Marian-corcodel.marian-gmail..patch --]
[-- Type: text/x-patch; name="0001-Signed-off-by-Corcodel-Marian-corcodel.marian-gmail..patch", Size: 996 bytes --]

diff --git a/drivers/net/ethernet/realtek/r8169.c b/drivers/net/ethernet/realtek/r8169.c
index 744f90a..714af89 100644
--- a/drivers/net/ethernet/realtek/r8169.c
+++ b/drivers/net/ethernet/realtek/r8169.c
@@ -8181,6 +8181,9 @@ static int rtl_init_one(struct pci_dev *pdev, const struct pci_device_id *ent)
 	else
 		tp->rx_buf_sz = 16383;
 
+	tp->event_slow = cfg->event_slow;
+
+
 	rtl_init_rxcfg(tp);
 
 	rtl_irq_disable(tp);
@@ -8189,7 +8192,7 @@ static int rtl_init_one(struct pci_dev *pdev, const struct pci_device_id *ent)
 
 	rtl_hw_reset(tp);
 
-	rtl_ack_events(tp, 0xffff);
+	rtl_ack_events(tp, 0xffff & tp->event_slow);
 
 	pci_set_master(pdev);
 
@@ -8325,7 +8328,7 @@ static int rtl_init_one(struct pci_dev *pdev, const struct pci_device_id *ent)
 	dev->hw_features |= NETIF_F_RXFCS;
 
 	tp->hw_start = cfg->hw_start;
-	tp->event_slow = cfg->event_slow;
+	//tp->event_slow = cfg->event_slow;
 
 	tp->opts1_mask = (tp->mac_version != RTL_GIGA_MAC_VER_01) ?
 		~(RxBOVF | RxFOVF) : ~0;

Re: [PATCH net-next]r8169: set bits on Register Interrupt status on limit

[Florian Fainelli]

On 16/07/15 03:18, Corcodel Marian wrote:
> 
>  Set bits on register Interrupt status on limits by
> configuration(critical).
>  On chips not alls bits is in use and some is reserved this patch solve this issue.
> 
>  Committer: Corcodel Marian <asu@192-168-0-3.rdsnet.ro>
>  Changes to be committed:
> 	modified:   drivers/net/ethernet/realtek/r8169.c

Unfortunately, this still does not look like a proper patch submission,
please take the time to read through Documentation/SubmittingPatches,
and also browse the netdev mailing-list for examples on what other
patches submission look like, e.g:
http://marc.info/?l=linux-netdev&m=143701078222680&w=2

If you use git format-patch and git send-email, things are made largely
easier than trying to manually do this.

> 
> Signed-off-by: Corcodel Marian <corcodel.marian@gmail.com>
> ---
>  drivers/net/ethernet/realtek/r8169.c | 7 +++++--
>  1 file changed, 5 insertions(+), 2 deletions(-)
> 


-- 
Florian

Re: [PATCH net-next]r8169: set bits on Register Interrupt status on limit

[Francois Romieu]

Corcodel Marian <corcodel.marian@gmail.com> :
> Set bits on register Interrupt status on limits by
> configuration(critical).
> On chips not alls bits is in use and some is reserved this patch solve
> this issue.

Did you experience a real bug or is it a theoretical issue ?

I don't mind experimental stuff provided:
- it's tested
- it's explained
- some effort has been done to know what Realtek has to say about it

Call me retentive but the explanations are mildly clear.

-- 
Ueimor