netdev.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: roopa <roopa@cumulusnetworks.com>
To: sfeldma@gmail.com
Cc: netdev@vger.kernel.org, jiri@resnulli.us, simon.horman@netronome.com
Subject: Re: [PATCH net-next v2 1/5] net: don't reforward packets already forwarded by offload device
Date: Thu, 16 Jul 2015 20:32:14 -0700	[thread overview]
Message-ID: <55A8773E.2020607@cumulusnetworks.com> (raw)
In-Reply-To: <1437033897-8050-2-git-send-email-sfeldma@gmail.com>

On 7/16/15, 1:04 AM, sfeldma@gmail.com wrote:
> From: Scott Feldman <sfeldma@gmail.com>
>
> Just before queuing skb for xmit on port, check if skb has been marked by
> switchdev port driver as already fordwarded by device.  If so, drop skb.  A
> non-zero skb->offload_fwd_mark field is set by the switchdev port
> driver/device on ingress to indicate the skb has already been forwarded by
> the device to egress ports with matching dev->skb_mark.  The switchdev port
> driver would assign a non-zero dev->skb_mark for each device port netdev
typo: dev->offload_fwd_mark
> during registration, for example.
>
> Signed-off-by: Scott Feldman <sfeldma@gmail.com>
>
Acked-by: Roopa Prabhu <roopa@cumulusnetworks.com>

Thanks scott!

  parent reply	other threads:[~2015-07-17  3:32 UTC|newest]

Thread overview: 16+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-07-16  8:04 [PATCH net-next v2 0/5] switchdev: avoid duplicate packet forwarding sfeldma
2015-07-16  8:04 ` [PATCH net-next v2 1/5] net: don't reforward packets already forwarded by offload device sfeldma
2015-07-16  8:22   ` Jiri Pirko
2015-07-17  3:32   ` roopa [this message]
2015-07-17 14:37   ` Nicolas Dichtel
2015-07-17 19:59     ` Scott Feldman
2015-07-16  8:04 ` [PATCH net-next v2 2/5] net: add phys ID compare helper to test if two IDs are the same sfeldma
2015-07-16  8:22   ` Jiri Pirko
2015-07-16  8:04 ` [PATCH net-next v2 3/5] switchdev: add offload_fwd_mark generator helper sfeldma
2015-07-16  8:22   ` Jiri Pirko
2015-07-16  8:04 ` [PATCH net-next v2 4/5] rocker: add offload_fwd_mark support sfeldma
2015-07-16  8:22   ` Jiri Pirko
2015-07-16  8:04 ` [PATCH net-next v2 5/5] switchdev: update documentation for offload_fwd_mark sfeldma
2015-07-16  8:22   ` Jiri Pirko
2015-07-16  8:23 ` [PATCH net-next v2 0/5] switchdev: avoid duplicate packet forwarding Jiri Pirko
2015-07-16  9:33 ` Simon Horman

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=55A8773E.2020607@cumulusnetworks.com \
    --to=roopa@cumulusnetworks.com \
    --cc=jiri@resnulli.us \
    --cc=netdev@vger.kernel.org \
    --cc=sfeldma@gmail.com \
    --cc=simon.horman@netronome.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).