From mboxrd@z Thu Jan 1 00:00:00 1970 From: Michal Simek Subject: Re: [RFC PATCH 0/2] net: macb: Add mdio driver for accessing multiple phy devices Date: Mon, 20 Jul 2015 15:30:36 +0200 Message-ID: <55ACF7FC.4020408@xilinx.com> References: <1436762920-32107-1-git-send-email-punnaia@xilinx.com> Mime-Version: 1.0 Content-Type: text/plain; charset=windows-1252 Content-Transfer-Encoding: 7bit Cc: harinik@xilinx.com, kpc528@gmail.com, kalluripunnaiahchoudary@gmail.com, netdev@vger.kernel.org, Punnaiah Choudary Kalluri To: Punnaiah Choudary Kalluri , nicolas.ferre@atmel.com, anirudh@xilinx.com, davem@davemloft.net Return-path: Received: from mail-bl2on0056.outbound.protection.outlook.com ([65.55.169.56]:7282 "EHLO na01-bl2-obe.outbound.protection.outlook.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S932604AbbGTPEZ (ORCPT ); Mon, 20 Jul 2015 11:04:25 -0400 In-Reply-To: <1436762920-32107-1-git-send-email-punnaia@xilinx.com> Sender: netdev-owner@vger.kernel.org List-ID: Hi Nicolas, have you had a time to look at this? Thanks, Michal On 07/13/2015 06:48 AM, Punnaiah Choudary Kalluri wrote: > This patch is to add support for the design that has multiple ethernet > mac controllers and single mdio bus connected to multiple phy devices. > i.e mdio lines are connected to any of the ethernet mac controller and > all the phy devices will be accessed using the phy maintenance interface > in that mac controller. > > ______ _____ > | | |PHY0 | > | MAC0 |-----------------| | > |______| | |_____| > | > ______ | _____ > | | | | | > | MAC1 | |_________|PHY1 | > |______| |____ | > > So, i come up with two implementations for addressing the above configuration. > > Implementation 1: > Have separate driver for mdio bus > Create a DT node for all the PHY devices connected to the mdio bus > This driver will share the register space of the mac controller that has > mdio bus connected. > > Implementation 2: > Add new property "has-mdio" and it should be 1 for the mac that has mdio bus > connected. > Create the mdio bus only when the has-mdio property is 1 > > Please review the two implementations and suggest which one is better to proceed > further. In my opinion implementation 1 will be the ideal one. > > Currently i have tested the patches with single mac and single phy > configuration. I need to take care of few more cases before releasing the final patch > but before that i would like to have your opinion on the above implementations > and finalize one implementation. so that i can enhance it further. > > Punnaiah Choudary Kalluri (1): > net: macb: Add mdio driver for accessing multiple phy devices > net: macb: Add support for single mac managing more than one phy > > > drivers/net/ethernet/cadence/Makefile | 2 +- > drivers/net/ethernet/cadence/macb.c | 93 +------------- > drivers/net/ethernet/cadence/macb.h | 3 +- > drivers/net/ethernet/cadence/macb_mdio.c | 204 ++++++++++++++++++++++++++++++ > 4 files changed, 211 insertions(+), 91 deletions(-) > create mode 100644 drivers/net/ethernet/cadence/macb_mdio.c >