From: Julien Grall <julien.grall@citrix.com>
To: <xen-devel@lists.xenproject.org>
Cc: <ian.campbell@citrix.com>, <netdev@vger.kernel.org>,
<stefano.stabellini@eu.citrix.com>,
<linux-kernel@vger.kernel.org>,
"David Vrabel" <david.vrabel@citrix.com>,
Boris Ostrovsky <boris.ostrovsky@oracle.com>,
<linux-arm-kernel@lists.infradead.org>
Subject: Re: [Xen-devel] [PATCH v2 17/20] net/xen-netfront: Make it running on 64KB page granularity
Date: Mon, 20 Jul 2015 18:26:06 +0100 [thread overview]
Message-ID: <55AD2F2E.9090204@citrix.com> (raw)
In-Reply-To: <1436474552-31789-18-git-send-email-julien.grall@citrix.com>
Hi,
On 09/07/15 21:42, Julien Grall wrote:
> +static void xennet_make_one_txreq(unsigned long mfn, unsigned int offset,
> + unsigned int *len, void *data)
> +{
> + struct xennet_gnttab_make_txreq *info = data;
> +
> + info->tx->flags |= XEN_NETTXF_more_data;
> + skb_get(info->skb);
> + xennet_make_one_txreq(mfn, offset, len, data);
This should be xennet_tx_setup_grant rather than calling itself. I did
the mistake while cleaning up the code sorry.
Regards,
--
Julien Grall
next prev parent reply other threads:[~2015-07-20 17:26 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <1436474552-31789-1-git-send-email-julien.grall@citrix.com>
2015-07-09 20:42 ` [PATCH v2 08/20] net/xen-netback: xenvif_gop_frag_copy: move GSO check out of the loop Julien Grall
2015-07-09 20:42 ` [PATCH v2 17/20] net/xen-netfront: Make it running on 64KB page granularity Julien Grall
2015-07-20 17:26 ` Julien Grall [this message]
2015-07-09 20:42 ` [PATCH v2 18/20] net/xen-netback: " Julien Grall
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=55AD2F2E.9090204@citrix.com \
--to=julien.grall@citrix.com \
--cc=boris.ostrovsky@oracle.com \
--cc=david.vrabel@citrix.com \
--cc=ian.campbell@citrix.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=stefano.stabellini@eu.citrix.com \
--cc=xen-devel@lists.xenproject.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).