* Re: [PATCH] netcp:Fix error handling in the function netcp_xgbe_serdes_config
[not found] <1437407684-1750-1-git-send-email-xerofoify@gmail.com>
@ 2015-07-21 14:57 ` Murali Karicheri
0 siblings, 0 replies; only message in thread
From: Murali Karicheri @ 2015-07-21 14:57 UTC (permalink / raw)
To: Nicholas Krause, w-kwok2; +Cc: netdev, linux-kernel
On 07/20/2015 11:54 AM, Nicholas Krause wrote:
> This fixes error handling in the function netcp_xgbe_serdes_config
> by putting the return value of netcp_xgbe_serdes_check_lane into
> the variable ret and return this value to the caller as this function
> can fail when called by returning the error code -ETIMEOUT.
>
> Signed-off-by: Nicholas Krause <xerofoify@gmail.com>
> ---
> drivers/net/ethernet/ti/netcp_xgbepcsr.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/net/ethernet/ti/netcp_xgbepcsr.c b/drivers/net/ethernet/ti/netcp_xgbepcsr.c
> index 33571ac..0c79e3d 100644
> --- a/drivers/net/ethernet/ti/netcp_xgbepcsr.c
> +++ b/drivers/net/ethernet/ti/netcp_xgbepcsr.c
> @@ -483,7 +483,7 @@ static int netcp_xgbe_serdes_config(void __iomem *serdes_regs,
> return ret;
>
> netcp_xgbe_serdes_enable_xgmii_port(sw_regs);
> - netcp_xgbe_serdes_check_lane(serdes_regs, sw_regs);
> + ret = netcp_xgbe_serdes_check_lane(serdes_regs, sw_regs);
> return ret;
> }
>
>
Nicholas,
Thanks for the patch.
Acked-by: Murali Karicheri <m-karicheri2@ti.com>
--
Murali Karicheri
Linux Kernel, Keystone
^ permalink raw reply [flat|nested] only message in thread
only message in thread, other threads:[~2015-07-21 14:57 UTC | newest]
Thread overview: (only message) (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
[not found] <1437407684-1750-1-git-send-email-xerofoify@gmail.com>
2015-07-21 14:57 ` [PATCH] netcp:Fix error handling in the function netcp_xgbe_serdes_config Murali Karicheri
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).