From: Florian Fainelli <f.fainelli@gmail.com>
To: Dan Murphy <dmurphy@ti.com>, netdev@vger.kernel.org
Cc: dcb314@hotmail.com
Subject: Re: [PATCH] net: phy: dp83867: Fix warning check for setting the internal delay
Date: Tue, 21 Jul 2015 10:14:12 -0700 [thread overview]
Message-ID: <55AE7DE4.1080404@gmail.com> (raw)
In-Reply-To: <1437498405-1723-1-git-send-email-dmurphy@ti.com>
On 21/07/15 10:06, Dan Murphy wrote:
> Fix warning: logical ‘or’ of collectively exhaustive tests is always true
>
> Change the internal delay check from an 'or' condition to an 'and'
> condition.
>
> Reported-by: David Binderman <dcb314@hotmail.com>
> Signed-off-by: Dan Murphy <dmurphy@ti.com>
Acked-by: Florian Fainelli <f.fainelli@gmail.com>
> ---
> drivers/net/phy/dp83867.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/net/phy/dp83867.c b/drivers/net/phy/dp83867.c
> index c7a12e2..8a3bf54 100644
> --- a/drivers/net/phy/dp83867.c
> +++ b/drivers/net/phy/dp83867.c
> @@ -164,7 +164,7 @@ static int dp83867_config_init(struct phy_device *phydev)
> return ret;
> }
>
> - if ((phydev->interface >= PHY_INTERFACE_MODE_RGMII_ID) ||
> + if ((phydev->interface >= PHY_INTERFACE_MODE_RGMII_ID) &&
> (phydev->interface <= PHY_INTERFACE_MODE_RGMII_RXID)) {
> val = phy_read_mmd_indirect(phydev, DP83867_RGMIICTL,
> DP83867_DEVADDR, phydev->addr);
>
--
Florian
next prev parent reply other threads:[~2015-07-21 17:16 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-07-21 17:06 [PATCH] net: phy: dp83867: Fix warning check for setting the internal delay Dan Murphy
2015-07-21 17:14 ` Florian Fainelli [this message]
2015-07-22 5:29 ` David Miller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=55AE7DE4.1080404@gmail.com \
--to=f.fainelli@gmail.com \
--cc=dcb314@hotmail.com \
--cc=dmurphy@ti.com \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).