netdev.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Daniel Borkmann <daniel@iogearbox.net>
To: David Laight <David.Laight@ACULAB.COM>
Cc: 'Jamal Hadi Salim' <jhs@mojatatu.com>,
	Neil Horman <nhorman@tuxdriver.com>,
	Vlad Yasevich <vyasevic@redhat.com>,
	David Miller <davem@davemloft.net>,
	"netdev@vger.kernel.org" <netdev@vger.kernel.org>,
	tuexen@fh-muenster.de
Subject: Re: [RFC net-next 1/1] : sctp: denoise deprecation log on SCTP_EVENTS
Date: Wed, 22 Jul 2015 14:04:02 +0200	[thread overview]
Message-ID: <55AF86B2.1020001@iogearbox.net> (raw)
In-Reply-To: <063D6719AE5E284EB5DD2968C1650D6D1CB6952D@AcuExch.aculab.com>

On 07/22/2015 01:48 PM, David Laight wrote:
> From: Jamal Hadi Salim
>> Sent: 09 July 2015 11:38
>>
>> In the newer kernels this message is extremely noisy. After a quick
>> discussion with Daniel it seems to me it will be very hard to get
>> existing apps that nobody is going to update to continue to work
>> (i.e no forward compat). And newer apps that desire to play in both
>> older kernels and new kernels will have to play some tricks to work
>> (i.e weak backward compatibility).  These are good reasons
>> to totally get rid of this message. At minimal to neutre it.
>> The attached change tries to do that. However, if you had multiple
>> apps, you will only get warning for the first one.
>
> Never mind spanning the kernel log, there will be performance
> issues with systems that are sending significant amounts of SCTP data.
> I'm not sure you'll get 10000+/sec through the trace system.

What do you mean by "trace system" (there's no backtrace)?

Anyway, as previously stated, I doubt we'd get rid of the deprecated
SCTP uapi from the RFC any time soon, so, imho, we should just remove
these rate-limited messages altogether to stop spamming the klog ...

> I'm going to have to find which version this trace went into and
> make sure we tell customers not to use the relevant kernel versions.
>
> 	David
>

  reply	other threads:[~2015-07-22 12:04 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-07-09 10:38 [RFC net-next 1/1] : sctp: denoise deprecation log on SCTP_EVENTS Jamal Hadi Salim
2015-07-09 11:54 ` Daniel Borkmann
2015-07-09 12:59   ` Marcelo Ricardo Leitner
2015-07-22 11:48 ` David Laight
2015-07-22 12:04   ` Daniel Borkmann [this message]
2015-07-22 12:30     ` Michael Tuexen
2015-07-22 14:36       ` Daniel Borkmann

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=55AF86B2.1020001@iogearbox.net \
    --to=daniel@iogearbox.net \
    --cc=David.Laight@ACULAB.COM \
    --cc=davem@davemloft.net \
    --cc=jhs@mojatatu.com \
    --cc=netdev@vger.kernel.org \
    --cc=nhorman@tuxdriver.com \
    --cc=tuexen@fh-muenster.de \
    --cc=vyasevic@redhat.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).