From mboxrd@z Thu Jan 1 00:00:00 1970 From: Florian Fainelli Subject: Re: [patch net-next 0/4] Introduce Mellanox Technologies Switch ASICs switchdev drivers Date: Mon, 27 Jul 2015 14:21:14 -0700 Message-ID: <55B6A0CA.4010207@gmail.com> References: <1437666216-3149-1-git-send-email-jiri@resnulli.us> <20150727202747.GA2123@nanopsycho.fritz.box> Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit Cc: Netdev , "David S. Miller" , idosch@mellanox.com, eladr@mellanox.com, "ogerlitz@mellanox.com" , Roopa Prabhu , Thomas Graf , Alexei Starovoitov , Jamal Hadi Salim , Daniel Borkmann , john fastabend , "simon.horman@netronome.com" , John Linville , Andy Gospodarek , Shrijeet Mukherjee , "nhorman@tuxdriver.com" To: Jiri Pirko , Scott Feldman Return-path: Received: from mail-pa0-f45.google.com ([209.85.220.45]:33366 "EHLO mail-pa0-f45.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1754638AbbG0VXS (ORCPT ); Mon, 27 Jul 2015 17:23:18 -0400 Received: by padck2 with SMTP id ck2so57377595pad.0 for ; Mon, 27 Jul 2015 14:23:17 -0700 (PDT) In-Reply-To: <20150727202747.GA2123@nanopsycho.fritz.box> Sender: netdev-owner@vger.kernel.org List-ID: On 27/07/15 13:27, Jiri Pirko wrote: > Mon, Jul 27, 2015 at 10:21:54PM CEST, sfeldma@gmail.com wrote: >> On Thu, Jul 23, 2015 at 8:43 AM, Jiri Pirko wrote: >>> This patchset introduces Mellanox Technologies Switch driver infrastructure >>> and support for SwitchX-2 ASIC. >> >> You guys did a great job on the driver; looking forward to seeing >> L2/L3 hooked up. Very nice, aesthetically pleasing code. > > Thanks! > >> >> Is this a ground-up rewrite or a port of the SDK? It's so clean and >> tight, I'm guessing a ground-up rewrite. > > It's rewritten from scratch. Only glanced through the driver, but this looks like really really nice and clean, very pleased to see such a driver being submitted. That is very encouraging and should inspire other companies in doing so, so thanks for doing this! -- Florian