From: roopa <roopa@cumulusnetworks.com>
To: David Miller <davem@davemloft.net>
Cc: tgraf@suug.ch, netdev@vger.kernel.org
Subject: Re: [PATCH net-next v3] af_mpls: fix undefined reference to ip6_route_output
Date: Mon, 27 Jul 2015 21:30:31 -0700 [thread overview]
Message-ID: <55B70567.6090402@cumulusnetworks.com> (raw)
In-Reply-To: <20150727.212041.2269026145203619118.davem@davemloft.net>
On 7/27/15, 9:20 PM, David Miller wrote:
> From: Roopa Prabhu <roopa@cumulusnetworks.com>
> Date: Mon, 27 Jul 2015 17:41:17 -0700
>
>> @@ -33,4 +33,11 @@ config MPLS_IPTUNNEL
>> ---help---
>> mpls ip tunnel support.
>>
>> +config MPLS_NEXTHOP_DEVLOOKUP
>> + bool "MPLS: nexthop oif dev lookup"
>> + depends on MPLS_ROUTING && INET && (IPV6 || IPV6=n)
>> + ---help---
>> + This enables mpls route nexthop dev lookup when oif is not
>> + specified by user
>
> This still allows the illegal combination, how did you test this?
>
> CONFIG_IPV6=m
> CONFIG_MPLS=y
> CONFIG_NET_MPLS_GSO=y
> CONFIG_MPLS_ROUTING=y
> CONFIG_MPLS_IPTUNNEL=y
> CONFIG_MPLS_NEXTHOP_DEVLOOKUP=y
>
> net/built-in.o: In function `find_outdev':
> af_mpls.c:(.text+0x17df41): undefined reference to `ip6_route_output'
>
> The situation that must be prevented is MPLS_ROUTING=y + IPV6=m,
> but that's exactly what is being allowed even after your patch.
>
> Again, how did you test this? Did you try the case that causes
> problems as indicated in the failure reports?
yes, I did test exactly the combination above. And also CONFIG_IPV6=m +
CONFIG_MPLS_ROUTING=m and others with CONFIG_IPV6=n. Am not sure how I
missed the error.... I will look again. Sorry about the iteration.
prev parent reply other threads:[~2015-07-28 4:30 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-07-28 0:41 [PATCH net-next v3] af_mpls: fix undefined reference to ip6_route_output Roopa Prabhu
2015-07-28 4:20 ` David Miller
2015-07-28 4:30 ` roopa [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=55B70567.6090402@cumulusnetworks.com \
--to=roopa@cumulusnetworks.com \
--cc=davem@davemloft.net \
--cc=netdev@vger.kernel.org \
--cc=tgraf@suug.ch \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).