From mboxrd@z Thu Jan 1 00:00:00 1970 From: roopa Subject: Re: [PATCH net-next v4] af_mpls: fix undefined reference to ip6_route_output Date: Tue, 28 Jul 2015 08:41:48 -0700 Message-ID: <55B7A2BC.2090509@cumulusnetworks.com> References: <1438065624-38229-1-git-send-email-roopa@cumulusnetworks.com> <1438088676.25794.19.camel@stressinduktion.org> Mime-Version: 1.0 Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit Cc: davem@davemloft.net, tgraf@suug.ch, netdev@vger.kernel.org To: Hannes Frederic Sowa Return-path: Received: from mail-pd0-f169.google.com ([209.85.192.169]:34364 "EHLO mail-pd0-f169.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752141AbbG1Plu (ORCPT ); Tue, 28 Jul 2015 11:41:50 -0400 Received: by pdbbh15 with SMTP id bh15so72694285pdb.1 for ; Tue, 28 Jul 2015 08:41:49 -0700 (PDT) In-Reply-To: <1438088676.25794.19.camel@stressinduktion.org> Sender: netdev-owner@vger.kernel.org List-ID: On 7/28/15, 6:04 AM, Hannes Frederic Sowa wrote: > On Mon, 2015-07-27 at 23:40 -0700, Roopa Prabhu wrote: >> From: Roopa Prabhu >> >> Undefined reference to ip6_route_output and ip_route_output >> was reported with CONFIG_INET=n and CONFIG_IPV6=n. >> >> This patch adds new CONFIG_MPLS_NEXTHOP_DEVLOOKUP >> to lookup nexthop device if user has not specified it >> in RTA_OIF attribute. Make CONFIG_MPLS_NEXTHOP_DEVLOOKUP >> depend on INET and (IPV6 || IPV6=n) because it >> uses ip6_route_output and ip_route_output. >> >> Reported-by: kbuild test robot >> Reported-by: Thomas Graf >> Signed-off-by: Roopa Prabhu >> --- >> >> v1 - v2: use IS_BUILTIN >> >> v2 - v3: Use new Kconfig option that depends on (IPV6 || IPV6=n) as >> suggested by Dave. Also uses IS_ERR as suggested by Thomas. >> >> v3 - v4: Include missed case of (MPLS_ROUTING=y && IPV6=m) reported by >> Dave. >> >> net/mpls/Kconfig | 8 ++++++++ >> net/mpls/af_mpls.c | 19 ++++++++++++++++++- >> 2 files changed, 26 insertions(+), 1 deletion(-) >> >> diff --git a/net/mpls/Kconfig b/net/mpls/Kconfig >> index 5c467ef..134764e 100644 >> --- a/net/mpls/Kconfig >> +++ b/net/mpls/Kconfig >> @@ -33,4 +33,12 @@ config MPLS_IPTUNNEL >> ---help--- >> mpls ip tunnel support. >> >> +config MPLS_NEXTHOP_DEVLOOKUP >> + bool "MPLS: nexthop oif dev lookup" >> + depends on MPLS_ROUTING && INET && \ >> + ((IPV6 && !(MPLS_ROUTING=y && IPV6=m)) || IPV6=n) >> + ---help--- >> + This enables mpls route nexthop dev lookup when oif is not >> + specified by user >> + > Urks. > > Can't you simply use ipv6_stub_impl.ipv6_dst_lookup with sk=NULL to do > that and don't have a run-time dependency on IPv6 at all (for the cost > of a function pointer). I did not realize that this could be an option. I now see vxlan using it. I will try it out. > Maybe same for IPv4? I would prefer leaving IPV4 alone with CONFIG_INET. IPV6 was my problem case. Let me see if i can fix that first without introducing a config option. Thanks, Roopa >