From: Alexei Starovoitov <ast@plumgrid.com>
To: Michael Holzheu <holzheu@linux.vnet.ibm.com>,
David Miller <davem@davemloft.net>
Cc: Martin Schwidefsky <schwidefsky@de.ibm.com>,
Daniel Borkmann <daniel@iogearbox.net>,
netdev@vger.kernel.org, linux-s390@vger.kernel.org
Subject: Re: [PATCH net-next 5/5] s390/bpf: recache skb->data/hlen for skb_vlan_push/pop
Date: Tue, 28 Jul 2015 10:19:28 -0700 [thread overview]
Message-ID: <55B7B9A0.5060606@plumgrid.com> (raw)
In-Reply-To: <1438092600-16221-6-git-send-email-holzheu@linux.vnet.ibm.com>
On 7/28/15 7:10 AM, Michael Holzheu wrote:
> Allow eBPF programs attached to TC qdiscs call skb_vlan_push/pop
> via helper functions. These functions may change skb->data/hlen.
> This data is cached by s390 JIT to improve performance of ld_abs/ld_ind
> instructions. Therefore after a change we have to reload the data.
>
> In case of usage of skb_vlan_push/pop, in the prologue we store
> the SKB pointer on the stack and restore it after BPF_JMP_CALL
> to skb_vlan_push/pop.
>
> Signed-off-by: Michael Holzheu<holzheu@linux.vnet.ibm.com>
Thanks!
Acked-by: Alexei Starovoitov <ast@plumgrid.com>
prev parent reply other threads:[~2015-07-28 17:19 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-07-28 14:09 [PATCH net-next 0/5] s390/bpf: recache skb->data/hlen for skb_vlan_push/pop Michael Holzheu
2015-07-28 14:09 ` [PATCH net-next 1/5] s390/bpf: clear correct BPF accumulator register Michael Holzheu
2015-07-28 14:09 ` [PATCH net-next 2/5] s390/bpf: Fix multiple macro expansions Michael Holzheu
2015-07-29 3:13 ` Joe Perches
2015-07-29 8:32 ` Michael Holzheu
2015-07-28 14:09 ` [PATCH net-next 3/5] s390/bpf: increase BPF_SIZE_MAX Michael Holzheu
2015-07-28 14:09 ` [PATCH net-next 4/5] s390/bpf: Only clear A and X for converted BPF programs Michael Holzheu
2015-07-28 14:10 ` [PATCH net-next 5/5] s390/bpf: recache skb->data/hlen for skb_vlan_push/pop Michael Holzheu
2015-07-28 17:19 ` Alexei Starovoitov [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=55B7B9A0.5060606@plumgrid.com \
--to=ast@plumgrid.com \
--cc=daniel@iogearbox.net \
--cc=davem@davemloft.net \
--cc=holzheu@linux.vnet.ibm.com \
--cc=linux-s390@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=schwidefsky@de.ibm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).