* [PATCH net-next] lwtunnel: Make lwtun_encaps[] static
@ 2015-07-29 7:45 Thomas Graf
2015-07-29 19:35 ` roopa
2015-07-30 5:59 ` David Miller
0 siblings, 2 replies; 3+ messages in thread
From: Thomas Graf @ 2015-07-29 7:45 UTC (permalink / raw)
To: davem; +Cc: netdev, Roopa Prabhu
Any external user should use the registration API instead of
accessing this directly.
Cc: Roopa Prabhu <roopa@cumulusnetworks.com>
Signed-off-by: Thomas Graf <tgraf@suug.ch>
---
include/net/lwtunnel.h | 3 ---
net/core/lwtunnel.c | 2 +-
2 files changed, 1 insertion(+), 4 deletions(-)
diff --git a/include/net/lwtunnel.h b/include/net/lwtunnel.h
index b020390..33bd309 100644
--- a/include/net/lwtunnel.h
+++ b/include/net/lwtunnel.h
@@ -31,9 +31,6 @@ struct lwtunnel_encap_ops {
int (*cmp_encap)(struct lwtunnel_state *a, struct lwtunnel_state *b);
};
-extern const struct lwtunnel_encap_ops __rcu *
- lwtun_encaps[LWTUNNEL_ENCAP_MAX+1];
-
#ifdef CONFIG_LWTUNNEL
static inline struct lwtunnel_state *
lwtstate_get(struct lwtunnel_state *lws)
diff --git a/net/core/lwtunnel.c b/net/core/lwtunnel.c
index 5f7fae7..c240c89 100644
--- a/net/core/lwtunnel.c
+++ b/net/core/lwtunnel.c
@@ -37,7 +37,7 @@ struct lwtunnel_state *lwtunnel_state_alloc(int encap_len)
}
EXPORT_SYMBOL(lwtunnel_state_alloc);
-const struct lwtunnel_encap_ops __rcu *
+static const struct lwtunnel_encap_ops __rcu *
lwtun_encaps[LWTUNNEL_ENCAP_MAX + 1] __read_mostly;
int lwtunnel_encap_add_ops(const struct lwtunnel_encap_ops *ops,
--
2.4.3
^ permalink raw reply related [flat|nested] 3+ messages in thread* Re: [PATCH net-next] lwtunnel: Make lwtun_encaps[] static
2015-07-29 7:45 [PATCH net-next] lwtunnel: Make lwtun_encaps[] static Thomas Graf
@ 2015-07-29 19:35 ` roopa
2015-07-30 5:59 ` David Miller
1 sibling, 0 replies; 3+ messages in thread
From: roopa @ 2015-07-29 19:35 UTC (permalink / raw)
To: Thomas Graf; +Cc: davem, netdev
On 7/29/15, 12:45 AM, Thomas Graf wrote:
> Any external user should use the registration API instead of
> accessing this directly.
>
> Cc: Roopa Prabhu <roopa@cumulusnetworks.com>
> Signed-off-by: Thomas Graf <tgraf@suug.ch>
Acked-by: Roopa Prabhu <roopa@cumulusnetworks.com>
thanks.
> ---
> include/net/lwtunnel.h | 3 ---
> net/core/lwtunnel.c | 2 +-
> 2 files changed, 1 insertion(+), 4 deletions(-)
>
> diff --git a/include/net/lwtunnel.h b/include/net/lwtunnel.h
> index b020390..33bd309 100644
> --- a/include/net/lwtunnel.h
> +++ b/include/net/lwtunnel.h
> @@ -31,9 +31,6 @@ struct lwtunnel_encap_ops {
> int (*cmp_encap)(struct lwtunnel_state *a, struct lwtunnel_state *b);
> };
>
> -extern const struct lwtunnel_encap_ops __rcu *
> - lwtun_encaps[LWTUNNEL_ENCAP_MAX+1];
> -
> #ifdef CONFIG_LWTUNNEL
> static inline struct lwtunnel_state *
> lwtstate_get(struct lwtunnel_state *lws)
> diff --git a/net/core/lwtunnel.c b/net/core/lwtunnel.c
> index 5f7fae7..c240c89 100644
> --- a/net/core/lwtunnel.c
> +++ b/net/core/lwtunnel.c
> @@ -37,7 +37,7 @@ struct lwtunnel_state *lwtunnel_state_alloc(int encap_len)
> }
> EXPORT_SYMBOL(lwtunnel_state_alloc);
>
> -const struct lwtunnel_encap_ops __rcu *
> +static const struct lwtunnel_encap_ops __rcu *
> lwtun_encaps[LWTUNNEL_ENCAP_MAX + 1] __read_mostly;
>
> int lwtunnel_encap_add_ops(const struct lwtunnel_encap_ops *ops,
^ permalink raw reply [flat|nested] 3+ messages in thread* Re: [PATCH net-next] lwtunnel: Make lwtun_encaps[] static
2015-07-29 7:45 [PATCH net-next] lwtunnel: Make lwtun_encaps[] static Thomas Graf
2015-07-29 19:35 ` roopa
@ 2015-07-30 5:59 ` David Miller
1 sibling, 0 replies; 3+ messages in thread
From: David Miller @ 2015-07-30 5:59 UTC (permalink / raw)
To: tgraf; +Cc: netdev, roopa
From: Thomas Graf <tgraf@suug.ch>
Date: Wed, 29 Jul 2015 09:45:40 +0200
> Any external user should use the registration API instead of
> accessing this directly.
>
> Cc: Roopa Prabhu <roopa@cumulusnetworks.com>
> Signed-off-by: Thomas Graf <tgraf@suug.ch>
Applied, thanks.
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2015-07-30 5:59 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2015-07-29 7:45 [PATCH net-next] lwtunnel: Make lwtun_encaps[] static Thomas Graf
2015-07-29 19:35 ` roopa
2015-07-30 5:59 ` David Miller
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).