From: Daniel Borkmann <daniel@iogearbox.net>
To: Cong Wang <cwang@twopensource.com>
Cc: David Miller <davem@davemloft.net>,
Alexei Starovoitov <ast@plumgrid.com>,
Jamal Hadi Salim <jhs@mojatatu.com>,
netdev <netdev@vger.kernel.org>
Subject: Re: [PATCH net] net: sched: fix refcount imbalance in actions
Date: Thu, 30 Jul 2015 22:01:57 +0200 [thread overview]
Message-ID: <55BA82B5.4070602@iogearbox.net> (raw)
In-Reply-To: <CAHA+R7NOZadKESRmSZpWxmdG9wRg+15cHbc5H_zUgp77zofPZA@mail.gmail.com>
On 07/30/2015 08:48 PM, Cong Wang wrote:
...
> Right, I think your patch should be fine for net. The code is kinda messy,
> but we can always clean up the logic for net-next.
I agree with you. I.e. there could just be a single refcount taking care
of the cleanup/destruction, etc.
> Reviewed-by: Cong Wang <cwang@twopensource.com>
>
> (It looks like mirred doesn't handle bind == true case correctly, I will send a
> separated for it after your patch.)
Okay. Thanks for the review Cong!
Cheers,
Daniel
next prev parent reply other threads:[~2015-07-30 20:02 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-07-29 21:35 [PATCH net] net: sched: fix refcount imbalance in actions Daniel Borkmann
2015-07-30 0:33 ` Cong Wang
2015-07-30 0:55 ` Daniel Borkmann
2015-07-30 18:48 ` Cong Wang
2015-07-30 20:01 ` Daniel Borkmann [this message]
2015-07-30 21:21 ` David Miller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=55BA82B5.4070602@iogearbox.net \
--to=daniel@iogearbox.net \
--cc=ast@plumgrid.com \
--cc=cwang@twopensource.com \
--cc=davem@davemloft.net \
--cc=jhs@mojatatu.com \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).